From owner-freebsd-net@freebsd.org Thu Sep 5 17:56:29 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DB02EEEFF6 for ; Thu, 5 Sep 2019 17:56:29 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46PSzx1Xx6z4B9Y for ; Thu, 5 Sep 2019 17:56:28 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd2a.google.com with SMTP id u185so6710189iod.10 for ; Thu, 05 Sep 2019 10:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=10jwpV5Cs2PwEsT5FrAHTZ9kLgpj72EyhpF2Uty9pRg=; b=qgIDGYRjnVYBrMLGCVhlvX5yGIRMCFIg8NS1VPd2/PLJ7RETQ2X0cueA7/7Z2QhdLH a4CDU097b2DbO8SsWlk8RT9+W9iM1Q6esFUP22Ffcpw7hHYJ72iQiXZyUwfw7//uM4q/ 4PmXD0TOdcPryAGGXDNERTs7WpcPA44AkK/Filf03EMZ1uhSbCxTWekfSyrU6V+HXFf2 6Vb7+mIrZh71MC6A5svKcFNiCiqRBEcxKwZQ3+n5GiB+0beyQPDSnOYiOa8sR+thqnAe yi1YF39vMa52m5YnYVGhsQA8B4gzZxXhAkgLWc7yNdqy7wJgxy5zT+6n9X/6MHC2BKkN thFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=10jwpV5Cs2PwEsT5FrAHTZ9kLgpj72EyhpF2Uty9pRg=; b=WiH4yJnao5vSIVfGfdm+vFtyKXouf47fPdtjvkuAy6FJ/s3EURQx/Sltuzy24GVsXB kYLG4gdvpSZc7QBuJ+FykG2Ds54FtttnflPCO3HjdqLsf9ymAog84sHbSmKbO4GCN+UI q3LAfhqpuNVfzNeWgsCPjJuELGEirdia2jr7uyVVL23BynKPXX4bsl3NhgWVSoDeFz5w eGr3NhQgpcZEVJfBVCNlAIsavu7lofs/skrh+H2+YnTumyiCGnh/s8hL5PxnQX6A0HG5 R0NNMxZSPUMJjGsYxs66E1VjpRq8Oo2E8eSOt64MQsTNDj4nYIjUZyU7ECFva021piFc JtWA== X-Gm-Message-State: APjAAAW/rwlqSLX9LYnlr+thA9Wn2s2eVLVel2cDBeL8gGPrHe7l3WvK WgXhBQ9Ozv/v05ZbspO/Uy7KVN1qva/uZzdLhOFfwQ== X-Google-Smtp-Source: APXvYqx/AvkmbmSaazAlY5paMloBDnFOhIlFNF+AsQAsMZo6t5DUw2v9YlKdcsVuYjNzCYpX+KJofTu2Vi8VzoJRV8E= X-Received: by 2002:a5d:9591:: with SMTP id a17mr5542199ioo.303.1567706188215; Thu, 05 Sep 2019 10:56:28 -0700 (PDT) MIME-Version: 1.0 From: vm finance Date: Thu, 5 Sep 2019 10:56:16 -0700 Message-ID: Subject: maxburst in tcp_output.c To: freebsd-net@freebsd.org X-Rspamd-Queue-Id: 46PSzx1Xx6z4B9Y X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=qgIDGYRj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d2a as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-0.998,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-5.59), ipnet: 2607:f8b0::/32(-2.76), asn: 15169(-2.27), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_IN_DNSWL_NONE(0.00)[a.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2019 17:56:29 -0000 Hello everyone, I notice that maxburst check towards the end of tcp_output.c is #if 0 out for quite sometime now. I was trying to understand why this piece of code is still present in released version...is it safe to enable and use it for cubic/bbr algorithms? The comment there says it breaks newreno - any comments on impact of this on other CC algorithms? I notice that it helps in smoothing the traffic flow. Thanks in advance for sharing your thoughts!