Date: Thu, 27 Aug 2015 17:22:51 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 202404] [MAINTAINER] multimedia/mplayer2: updates to Makefile Message-ID: <bug-202404-13-8PRk1Mb3Il@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-202404-13@https.bugs.freebsd.org/bugzilla/> References: <bug-202404-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202404 --- Comment #32 from Jan Beich <jbeich@FreeBSD.org> --- I've landed easy changes. Please, rebase. Option helpers need more work i.e., not complete until bsd.port.options.mk line is gone. For one, I'd kill the following block without mercy: #On i386, gcc runs out of general purpose registers when #trying to compile a debug version with the default flags. .if ${PORT_OPTIONS:MDEBUG} .if ${ARCH} == "i386" DEBUG_FLAGS= -g -O -fomit-frame-pointer .endif .else .if defined(PACKAGE_BUILDING) CONFIGURE_ARGS+= --enable-runtime-cpudetection CFLAGS+= -O2 -fomit-frame-pointer .else CONFIGURE_ENV+= CPPFLAGS= CFLAGS= LDFLAGS= .endif .endif o Compiler-specific hacks should be properly enlosed. gcc42 is not used by default since FreeBSD 10. Convert to COMPILER_VERSION if the statement in the comment is still correct. o -O2 is in CFLAGS by default o -fomit-frame-pointer is harmful both for profiling and debugging o --enable-runtime-cpudetection should be converted to RTCPU, see multimedia/mplayer o Erasing user-provided *FLAGS is a foot-shooting prevention. We have packages for those who cannot properly sanitize their environment. See Porter's Handbook chapter on respecting CFLAGS. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-202404-13-8PRk1Mb3Il>