From owner-freebsd-fs@FreeBSD.ORG Thu Mar 28 05:32:09 2013 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 3A5911A1; Thu, 28 Mar 2013 05:32:09 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id A74138FE; Thu, 28 Mar 2013 05:32:08 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.6/8.14.6) with ESMTP id r2S5W5u4047614; Thu, 28 Mar 2013 07:32:05 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.0 kib.kiev.ua r2S5W5u4047614 Received: (from kostik@localhost) by tom.home (8.14.6/8.14.6/Submit) id r2S5W5T1047613; Thu, 28 Mar 2013 07:32:05 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 28 Mar 2013 07:32:05 +0200 From: Konstantin Belousov To: mdf@FreeBSD.org Subject: Re: [RFC] use a shared lock for VOP_GETEXTATTR Message-ID: <20130328053205.GF3794@kib.kiev.ua> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MZTSf4zogrZAfwtT" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2013 05:32:09 -0000 --MZTSf4zogrZAfwtT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 27, 2013 at 06:37:51PM -0700, mdf@FreeBSD.org wrote: > VOP_GETEXTATTR is currently called with an exclusive lock, which seems > like overkill for what is essentially a read operation. I had a look > over the various in-tree filesystems and it didn't look like any of > them will have a problem if a shared-mode lock is used for > vop_getextattr. >=20 > Does anyone know otherwise? Is someone using extended attributes > regularly who can test this? I think this change should be fine. At least it seems to for UFS. What other filesystems did you audited ? --MZTSf4zogrZAfwtT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRU9XUAAoJEJDCuSvBvK1BKGgP+warWw/Mo9pcf9zIj+cBE3PZ 9sdXjWUcCKqIM1pOFlURH2odq9P1+5Va7wP2n5jYBYUdri0SoCfQ/C86jvUkvaNS xKrMtNXIq38eKCCWU34+rFNhF9bg+rS0KS8FXI5+nnsbDsWaB0PeCXBSrfudeTv+ HFfGFmGLQvJdzYfvZ6LWInWw8BhgyrLX0/A/xAnPwlZDLrw1RbtAL51XRH/PHliv KfsxlyMoiTqJLDR7jX0EPiIcg+WENyUgwQ/SJTZ4i3a52y8eXLlSzHIhrinHPmnE b3iCc3TTZCRJYx0cOJMjLzk/d1kIVTYgRZ+Sdap1UjHeFw+E8Ps3Ev2T3BCzYCzG eTZBdffzcDW6xxc7zYfNDeiUvKEq3uKsBY9AyQeZWn5vEOsFSYFXc4TV/Q/OT+VM /hcdbgqcjDh2rXVJo1XHkpb+6mMZN4HWOo/r8Q+jVk2q/5RCmeQCN8tmbmWI4jIr j/hYA4zvH6cuEJ3iDghDV4urgb11VZ/Ybyx3At26J4jlUqW0B9MvIbvyRTnGiQt5 A95rE6tR0sfiMCRYrXs+pWR82DboNtv5PaQ6Wo5M+/hcweU1xjuJ/ris6EJVXUuU vcHp2dGMabmPzzFNPuN6lLh0VtOx1M57wJ/3ZV6xdDdZAeKrI0/GoU+CvqT/ONPR pPPVG6W9gpNZ8OpRB1sl =4mql -----END PGP SIGNATURE----- --MZTSf4zogrZAfwtT--