From owner-freebsd-current Thu Jul 4 6:31:15 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 17FE137B400 for ; Thu, 4 Jul 2002 06:31:11 -0700 (PDT) Received: from netscum.dyndns.dk (dclient217-162-144-72.hispeed.ch [217.162.144.72]) by mx1.FreeBSD.org (Postfix) with ESMTP id ADD1A43E31 for ; Thu, 4 Jul 2002 06:31:09 -0700 (PDT) (envelope-from bounce@netscum.dyndns.dk) Received: from netscum.dyndns.dk (localhost [127.0.0.1]) by netscum.dyndns.dk (8.12.2/8.12.2) with ESMTP id g64DV7nc072419 for ; Thu, 4 Jul 2002 15:31:07 +0200 (CEST) (envelope-from bounce@netscum.dyndns.dk) Received: (from root@localhost) by netscum.dyndns.dk (8.12.2/8.12.2/Submit) id g64DV6jO072418; Thu, 4 Jul 2002 15:31:06 +0200 (CEST) Date: Thu, 4 Jul 2002 15:31:06 +0200 (CEST) Message-Id: <200207041331.g64DV6jO072418@netscum.dyndns.dk> From: BOUWSMA Beery Organization: Men not wearing any pants that dont shave To: freebsd-current@freebsd.org References: <200206271409.g5RE9sYk065255@netscum.dyndns.dk> Subject: Re: duplicate includes in kdump/ioctl.c ? X-Hacked: via telnet to your port 25, what else? X-Internet-Access-Provided-By: CABAL MODEM (all hail CABAL) X-NetScum: Yes X-One-And-Only-Real-True-Fluffy: No Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Sorry to answer myself, but after a bit of free time to reflect on this, I may as well talk back at myself. I wrote: > Am I the only one getting duplicated #include lines in the generated > ioctl.c file, created as part of building usr.bin/kdump? YES! > 27 #include > 28 #include > 29 #include > 30 #include > 31 #include > 32 #include > However, there seem to be significant differences between the two > generated ioctl.c files (including another duplicated disklabel.h line). Yow. A clue, that points to: > ... Or might the > fact that I'm using a unionfs mount over /usr/src have something to > do with it (since disklabel.h appears twice with `ls' since I needed > to hack it in the upper unionfs layer)... It is. There's a shadow `scsi' directory that appears under -current (at least, that I'm still using) with a unionfs mount under `ls' twice, and gets traversed twice as well by the `find' that I should have noted had I had the time to pay attention to the mkioctls innards, leading to the duplicate inclusions. So I've added a `sort -u' into the `find' pipeline in hopes of quenching the duplicated includes that appear due to this imperfection of the unionfs. We'll see how it goes... The only way anyone else *might* see this is if they too do a unionfs mount, to keep an unmolested /usr/src around while still allowing one to hack on bits and pieces of it with local customizations, like my hack to mkioctls... Sorry for the noise, but in case anyone else might see such a thing, I thought I'd put this into the archives And, in fact, I've successfully built `kdump' as part of my normal `buildworld', so it seems as if I may even be well on the way to a successful build of -current. Yay. thanks barry bouwsma To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message