Date: Sat, 20 Aug 2022 17:34:51 GMT From: Konstantin Belousov <kib@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: da39a100dbfe - main - sleepq_check_ast_sc_locked(): update comment Message-ID: <202208201734.27KHYpZa093288@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=da39a100dbfe60da6512a8b230386b1105c42445 commit da39a100dbfe60da6512a8b230386b1105c42445 Author: Konstantin Belousov <kib@FreeBSD.org> AuthorDate: 2022-08-12 00:19:36 +0000 Commit: Konstantin Belousov <kib@FreeBSD.org> CommitDate: 2022-08-20 17:33:17 +0000 sleepq_check_ast_sc_locked(): update comment The relock order is important not only for a signal delivery, but also for the suspension requests. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 3 days Differential revision: https://reviews.freebsd.org/D36207 --- sys/kern/subr_sleepqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/subr_sleepqueue.c b/sys/kern/subr_sleepqueue.c index b5245879a05f..112dbbf93960 100644 --- a/sys/kern/subr_sleepqueue.c +++ b/sys/kern/subr_sleepqueue.c @@ -482,7 +482,7 @@ sleepq_check_ast_sc_locked(struct thread *td, struct sleepqueue_chain *sc) * Lock the per-process spinlock prior to dropping the * PROC_LOCK to avoid a signal delivery race. * PROC_LOCK, PROC_SLOCK, and thread_lock() are - * currently held in tdsendsignal(). + * currently held in tdsendsignal() and thread_single(). */ PROC_SLOCK(p); mtx_lock_spin(&sc->sc_lock);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202208201734.27KHYpZa093288>