From nobody Thu Aug 4 14:33:05 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LzB6J2rFjz4Y0c2 for ; Thu, 4 Aug 2022 14:33:12 +0000 (UTC) (envelope-from tsoome@me.com) Received: from pv50p00im-ztdg10021201.me.com (pv50p00im-ztdg10021201.me.com [17.58.6.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4LzB6H4rHlz3HXf for ; Thu, 4 Aug 2022 14:33:11 +0000 (UTC) (envelope-from tsoome@me.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1659623590; bh=Tqj+VS6gSswcA5kzQ/8r2L76U6TghnOaV3rCUahL650=; h=From:Message-Id:Content-Type:Mime-Version:Subject:Date:To; b=lxRBuhlS6BiUX0ysU4pAMq03oxrUoB93tV21JBs9RdVy5IOLvObrULpw7EThEI1zI 1grPGw6M6IC4Oxi9i0iCeySvN/3jC09CYadpX8XVLABFX7KocFval6p4rlM1DQdBf3 dYnG5cejgMjo3h+BvKSDyq8wsQytjrXiVTfAEf6vSfilNr7smwIqMQ9alKz30CYXG+ 67+sHzyl0kZFm8Hh1z2lv2lnbHu5lClvEwbPHtAoR0NXO0rzdVq84Dt4pOX8ClMGEB Wh+5XTlgGV55MVtQSsuBTY/OfqHT2QaMnUrdGAQMYQuq8+Hg28XhjGT9usONKWBLXI TTv4DfpK5k1kA== Received: from smtpclient.apple (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10021201.me.com (Postfix) with ESMTPSA id 6989D680664; Thu, 4 Aug 2022 14:33:08 +0000 (UTC) From: Toomas Soome Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_45F67029-A3A2-41BC-9F27-53F8BB6CE4C3" List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: RES: vt newcons 3 clicks mouse paste issue FIXED Date: Thu, 4 Aug 2022 17:33:05 +0300 In-Reply-To: Cc: Hans Petter Selasky , "freebsd-current@freebsd.org" To: Ivan Quitschal References: <41ef5c38-515f-739a-cb47-7cab0e609526@selasky.org> <20220623014847.067b18a5ba388639cf6009ce@dec.sakura.ne.jp> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Proofpoint-ORIG-GUID: LCBqtHL3-0vy4dMls2M-dXwUk_-Jt7j3 X-Proofpoint-GUID: LCBqtHL3-0vy4dMls2M-dXwUk_-Jt7j3 X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.883,17.11.64.514.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F08:2022-06-21=5F01,2022-06-21=5F08,2022-02-23?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=0 clxscore=1011 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2208040064 X-Rspamd-Queue-Id: 4LzB6H4rHlz3HXf X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=me.com header.s=1a1hai header.b=lxRBuhlS; dmarc=pass (policy=quarantine) header.from=me.com; spf=pass (mx1.freebsd.org: domain of tsoome@me.com designates 17.58.6.45 as permitted sender) smtp.mailfrom=tsoome@me.com X-Spamd-Result: default: False [-1.32 / 15.00]; URI_COUNT_ODD(1.00)[9]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[me.com,quarantine]; NEURAL_SPAM_MEDIUM(0.28)[0.276]; R_DKIM_ALLOW(-0.20)[me.com:s=1a1hai]; R_SPF_ALLOW(-0.20)[+ip4:17.58.0.0/16]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[17.58.6.45:from]; FREEFALL_USER(0.00)[tsoome]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[me.com:dkim]; RWL_MAILSPIKE_POSSIBLE(0.00)[17.58.6.45:from]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; ARC_NA(0.00)[]; ASN(0.00)[asn:714, ipnet:17.58.0.0/20, country:US]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_FROM(0.00)[me.com]; HAS_WP_URI(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[me.com:+]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_TO(0.00)[hotmail.com]; FREEMAIL_ENVFROM(0.00)[me.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_45F67029-A3A2-41BC-9F27-53F8BB6CE4C3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 4. Aug 2022, at 17:04, Ivan Quitschal wrote: >=20 > Hi Hans >=20 > D36042 created > How can I include more patch files in the same defect number? D36042 > https://reviews.freebsd.org/D36042 >=20 > Its missing the vt.h.diff and vt_core.diff > Both attached >=20 > Should i have put all three in the raw patch creation combo box when I = was creating the defect? > Sorry my dumbness , never used that phabricator=20 >=20 > --tzk You may want to check =E2=80=98git arc=E2=80=99 = (https://freebsdfoundation.org/wp-content/uploads/2021/11/FreeBSD-Code-Rev= iew-with-git-arc.pdf = ) rgds, toomas >=20 >=20 >=20 >=20 >=20 >> -----Mensagem original----- >> De: Ivan Quitschal >> Enviada em: ter=C3=A7a-feira, 2 de agosto de 2022 09:34 >> Para: Hans Petter Selasky >> Cc: Tomoaki AOKI ; Ivan Quitschal >> ; freebsd-current@freebsd.org; Kurt Jaeger >> >> Assunto: vt newcons 3 clicks mouse paste issue FIXED >>=20 >>=20 >> Hi guys >>=20 >> Currently , if you click 3 times in order to select the entire row, = its just not >> working as it should. >> i fixed that please find below and attached the patches >>=20 >> With this change now we can do a 3 clicks and paste , i dont know, in = some >> command, and it will be executed just fine, like it was in syscons, = and still is in >> xterm/ linux etc >>=20 >> now if the event is a 3 mouse clickss select, the space trim is made = on the right >> and an is included >>=20 >> thanks >>=20 >> --tzk >>=20 >>=20 >> -------------------- >> --- sys/dev/vt/vt_buf.c.orig 2022-08-02 08:44:27.229782000 -0300 >> +++ sys/dev/vt/vt_buf.c 2022-08-02 08:45:02.703697000 -0300 >> @@ -771,7 +771,7 @@ >> } >>=20 >> void >> -vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz) >> +vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz, = int >> +mark) >> { >> int i, j, r, c, cs, ce; >> term_pos_t s, e; >> @@ -799,7 +799,7 @@ >> buf[i++] =3D vb->vb_rows[r][c]; >>=20 >> /* For all rows, but the last one. */ >> - if (r !=3D e.tp_row) { >> + if (r !=3D e.tp_row || mark =3D=3D VTB_MARK_ROW) { >> /* Trim trailing word separators, if any. */ >> for (; i !=3D j; i--) { >> if (!tchar_is_word_separator(buf[i - = 1])) >> -------------------- >>=20 >> --- sys/dev/vt/vt_core.c.orig 2022-08-02 08:43:15.436415000 -0300 >> +++ sys/dev/vt/vt_core.c 2022-08-02 08:43:49.120096000 -0300 >> @@ -2287,7 +2287,7 @@ >> VD_PASTEBUFSZ(vd) =3D len; >> } >> /* Request copy/paste buffer data, no more than `len' = */ >> - vtbuf_extract_marked(&vw->vw_buf, VD_PASTEBUF(vd), = len); >> + vtbuf_extract_marked(&vw->vw_buf, VD_PASTEBUF(vd), = len, >> + mark); >>=20 >> VD_PASTEBUFLEN(vd) =3D len; >>=20 >> --------------------- >>=20 >> --- sys/dev/vt/vt.h.orig 2022-08-02 08:41:23.888584000 -0300 >> +++ sys/dev/vt/vt.h 2022-08-02 08:41:54.504309000 -0300 >> @@ -238,7 +238,7 @@ >> #ifndef SC_NO_CUTPASTE >> int vtbuf_set_mark(struct vt_buf *vb, int type, int col, int row); >> int vtbuf_get_marked_len(struct vt_buf *vb); -void >> vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz); >> +void vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int = sz, >> +int >> mark); >> #endif >>=20 >> #define VTB_MARK_NONE 0 >> -------------------------- > --Apple-Mail=_45F67029-A3A2-41BC-9F27-53F8BB6CE4C3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 4. Aug 2022, at 17:04, Ivan Quitschal <tezeka@hotmail.com> = wrote:

Hi Hans

D36042 created
How can I include more patch files in the same defect number? = D36042
https://reviews.freebsd.org/D36042

Its missing the vt.h.diff and vt_core.diff
Both = attached

Should i have put all three in the = raw patch creation combo box when I was creating the defect?
Sorry my dumbness  , never used that phabricator

--tzk


rgds,
toomas





-----Mensagem = original-----
De: Ivan Quitschal <tezeka@hotmail.com>
Enviada em: = ter=C3=A7a-feira, 2 de agosto de 2022 09:34
Para: Hans = Petter Selasky <hps@selasky.org>
Cc: Tomoaki AOKI <junchoon@dec.sakura.ne.jp>; Ivan Quitschal
<tezeka@hotmail.com>; freebsd-current@freebsd.org; Kurt Jaeger
<pi@freebsd.org>
Assunto: vt newcons 3 = clicks mouse paste issue FIXED


Hi guys

Currently , if you click = 3 times in order to select the entire row, its just not
working as it should.
i fixed that please find = below and attached the patches

With this = change now we can do a 3 clicks and paste , i dont know, in some
command, and it will be executed just fine, like it was in = syscons, and still is in
xterm/ linux etc

now if the event is a 3 mouse clickss select, the space trim = is made on the right
and an <enter> is included

thanks

--tzk


--------------------
--- sys/dev/vt/vt_buf.c.orig    2022-08-02 = 08:44:27.229782000 -0300
+++ sys/dev/vt/vt_buf.c = 2022-08-02 08:45:02.703697000 -0300
@@ -771,7 +771,7 @@
 }

 void
-vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, = int sz)
+vtbuf_extract_marked(struct vt_buf *vb, = term_char_t *buf, int sz, int
+mark)
=  {
=         int i, j, r, c, cs, = ce;
=         term_pos_t s, e;
@@ -799,7 +799,7 @@
=             &n= bsp;           buf[= i++] =3D vb->vb_rows[r][c];

=             &n= bsp;   /* For all rows, but the last one. */
- =             &n= bsp; if (r !=3D e.tp_row) {
+ =             &n= bsp; if (r !=3D e.tp_row || mark =3D=3D VTB_MARK_ROW) {
=             &n= bsp;           /* = Trim trailing word separators, if any. */
=             &n= bsp;           for = (; i !=3D j; i--) {
=             &n= bsp;           &nbs= p;       if = (!tchar_is_word_separator(buf[i - 1]))
--------------------

--- = sys/dev/vt/vt_core.c.orig   2022-08-02 08:43:15.436415000 = -0300
+++ sys/dev/vt/vt_core.c =        2022-08-02 08:43:49.120096000 = -0300
@@ -2287,7 +2287,7 @@
=             &n= bsp;           VD_P= ASTEBUFSZ(vd) =3D len;
=             &n= bsp;   }
=             &n= bsp;   /* Request copy/paste buffer data, no more than = `len' */
- =             &n= bsp; vtbuf_extract_marked(&vw->vw_buf, VD_PASTEBUF(vd), = len);
+ =             &n= bsp; vtbuf_extract_marked(&vw->vw_buf, VD_PASTEBUF(vd), = len,
+ mark);

=             &n= bsp;   VD_PASTEBUFLEN(vd) =3D len;

---------------------

--- = sys/dev/vt/vt.h.orig =        2022-08-02 08:41:23.888584000 = -0300
+++ sys/dev/vt/vt.h =     2022-08-02 08:41:54.504309000 -0300
@@ -238,7 +238,7 @@
 #ifndef = SC_NO_CUTPASTE
 int vtbuf_set_mark(struct vt_buf = *vb, int type, int col, int row);
 int = vtbuf_get_marked_len(struct vt_buf *vb); -void
vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int = sz);
+void vtbuf_extract_marked(struct vt_buf *vb, = term_char_t *buf, int sz,
+int
mark);
 #endif

 #define =        VTB_MARK_NONE =           0
--------------------------
<vt.h.diff><vt_core.diff>

= --Apple-Mail=_45F67029-A3A2-41BC-9F27-53F8BB6CE4C3--