Date: Thu, 22 Feb 2024 10:59:38 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Max Brazhnikov <makc@freebsd.org> Cc: Nuno Teixeira <eduardo@freebsd.org>, Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 48437516330b - main - www/nghttp2: Remove unnecessary substitution Message-ID: <4b75z3c7itpd4r6iakji6ccfez7buknwl3lwh47jlbcttv2egg@no5ifeo2i5ky> In-Reply-To: <CAJie3yrwPM5QFj5=c1%2BCR3vQgdfgU8a2d7eJOt%2BS1CdVHMWnDw@mail.gmail.com> References: <202402211520.41LFKHJO027649@gitrepo.freebsd.org> <CAFDf7UJ6m%2Bnu02o4JsJVhCH%2B7nARGm%2BUbaUPENLSCtbvAAS3dQ@mail.gmail.com> <CAJie3yrwPM5QFj5=c1%2BCR3vQgdfgU8a2d7eJOt%2BS1CdVHMWnDw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nnrdqcuqllabw3gs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 22, 2024 at 12:32:44PM +0300, Max Brazhnikov wrote: > On Thu, 22 Feb 2024 at 11:01, Nuno Teixeira <eduardo@freebsd.org> wrote: > > > > Hello, > > > > What's going on? > > > > -DISTVERSION=3D 1.59.0 > > +PORTVERSION=3D 1.59.0 > > > > Should Porter's Handbook be fixed? >=20 > Or veteran committers should update their knowledge :) >=20 > Less jokingly, the problem with DISTVERSION/PORTVERSION is that the > Porters's Handbook and ports framework are out of sync. Somebody has > decided that DISTVERSION is higher than PORTVERSION (makes sense for > me, if you want my opinion) and has commited update to the handbook. > However, the framework has not been changed, it checks for PORTVERSION > first, while DISTVERSION is derived from PORTVERSION. >=20 > If we want to switch to DISTVERSION and deprecate PORTVERSION, we > should update the framework and docs and CHANGES and notify people > before upcoming change and after. This applies to other changes in the > ports framework. That's fubar, we're not deprecating PORTVERSION, nor should we change the way they work inside the framework. It's only a if/else, it does not matter which way it goes. The algorithm is simple : 1) Use DISTVERSION, and thus, PORTVERSION is derived from it so that the port version is correct wrt what pkg expects. For example, 1.2.0-beta1 -> 1.2.0.b1 2) If the software version is non standard, DISTVERSION's automatic derivation does something funky, and the software version is something pkg can understand correctly, then use PORTVERSION. For example, 1.34a that is after 1.34 (aka not an alpha), as is done for sysutils/tmux 3) If it still does not work, set PORTVERSION and DISTNAME. For example the software version of 9.8.7-P1 that is after 9.8.7, and thus should have a port version of 9.8.7P1. In that case set PORTVERSION so the version is untouched, and set DISTNAME with foo-9.8.7-P1 as was done with very old versions of dns/bind9, say: https://cgit.freebsd.org/ports/tree/dns/bind98/Makefile?h=3D9a1f79615562= d0c5b74732c244790121c0c905b8 --=20 Mathieu Arnold --nnrdqcuqllabw3gs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXXGwlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb5TPQv8DCjBnRHCMto3yIQM22kp0FJ3SY/tHHp9Hm/jRS7HUJOEZKZMAwme0Tim n47+zSGQVbD3bH9ALIiEJjfvUh69Cq6Z65pRpWrqsA7rOpOUzPo1ijkKmVbk1VL3 ner7g732+ZolCURi8jkd0svPNYhhAz9l3LSIgHfc0CrZkfXsuEaPbzr9zZxlBFi3 T8JDwC5ngvd1oiu+Pn1Fjb01Jh8F1ip4wiGf5AXX4OhiX4QrSyDFXpa8232QTo36 JBtjAmSe2MVelHKZRwCpF2BVPJ9SLFhDO1jHIwnrf6MPBV1xKzkQ6WDm+hKodkze 0puTEPvwJZPqRbzkSBGiZX3+d9Lia5HbgBhP0xn6M865WTkC4QqIwHnSEIVUvQd8 t296OdzEgr5czNpk7JIYMytNN+OuEASf3wlWndfFsOQhCnerkvG7HOXBsvlgYVBf BZgZgRgvOJ8Ng3Oq/BowmsVZk2v2j1f3LuJoR2ToP4It1cGgOnfGiAsRsqmYMwlI LSVjgTCN =RraH -----END PGP SIGNATURE----- --nnrdqcuqllabw3gs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4b75z3c7itpd4r6iakji6ccfez7buknwl3lwh47jlbcttv2egg>