From owner-svn-src-head@freebsd.org Thu Dec 5 05:12:23 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D073E1BB25E for ; Thu, 5 Dec 2019 05:12:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47T3kG5DnXz3Hm0 for ; Thu, 5 Dec 2019 05:12:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x735.google.com with SMTP id q28so2258322qkn.10 for ; Wed, 04 Dec 2019 21:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FYE6jgn220PgnWFqFCDDol6fLcuWOSslpaEJMS3pmhE=; b=jnj6PGx1Ukym/tCVHzzKCxFSRcby8anXZpuE+jTfZdm4vk3gzp/JQUCMST2+Y8KBaF 8v6G3K3wW0K1DnfZj0AdYwDK6WkipZZfMgEoR8G+z9i242I//c1SsXcI9OsQ0Ruy38kj ymC4Y80dyflTC8AjDqMZXmzf7g8gYmVfkNUafvBR7cK5vcI8QmA/0NSP+zgsJ823bUu3 LaFD74K49nTIi7mlp22zcmZxyn8A0HF5C6w6wUEBdPdannOMjp/qBwFCzsp34EZPlS6f uWDuN43Zc0lyGTrICzdGDNwopfUx/ooYDIchdpHEcieRk0Bu305HZ8iSfkvGRde1CSUM remw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FYE6jgn220PgnWFqFCDDol6fLcuWOSslpaEJMS3pmhE=; b=phO3kEOh73oeDl2Ld4RDP4stpcCZzqR642Jly6zvT9nA/mPxFzZvQYZsYohwwz7qBK s6lDpN52sPjp72hZjtDNXwSVa//857EJS7Jjbh4KDFX+iA/MYWBCvDFHLis7eD4KMFdd NGfOEpRpV7KAlRKT7yjF4gFMdgkdpGjGP0KdgPAuOfcVR94oMRpulA81RSAo/GtxxS6n X5hRBi+0zxjneif4zvhJ2F1kKcMfgMsF+0DLtziP4PxPEVBVItVqypz4cbseZXeZt/4V J589Ogpe0RJ8xbmbZaYSOKqLIkDkVAbAcR0Bw5KYdpOrRTINxIuqadYZP1UzkvFRPzsF dIVQ== X-Gm-Message-State: APjAAAV4+eSc9nfotH6ohDkiEz2om/PW9ykxxjfr53YHxwed4AsQVOv2 jVG8YmAfSU4CMXkMl7E1tx27pwJ5ge1jjwS2WfZNjA== X-Google-Smtp-Source: APXvYqyuVRw/BC49GpMcgSJB+ajSny4oZFUtJ+rL8u8Mx2rsmt38Xob1zeT88xgZoWLFY73v4ZVRstgNp+RXh5oN6ws= X-Received: by 2002:a37:b0c5:: with SMTP id z188mr119802qke.215.1575522740851; Wed, 04 Dec 2019 21:12:20 -0800 (PST) MIME-Version: 1.0 References: <201912050452.xB54qKV0080126@repo.freebsd.org> <516874DA-E57F-4EAA-852B-1129A95BB998@panasas.com> In-Reply-To: <516874DA-E57F-4EAA-852B-1129A95BB998@panasas.com> From: Warner Losh Date: Wed, 4 Dec 2019 22:12:09 -0700 Message-ID: Subject: Re: svn commit: r355412 - head/sys/geom To: Ravi Pokala Cc: Alexander Motin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 47T3kG5DnXz3Hm0 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=jnj6PGx1; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::735) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.71 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[5.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.71)[ip: (-9.35), ipnet: 2607:f8b0::/32(-2.23), asn: 15169(-1.93), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Dec 2019 05:12:23 -0000 On Wed, Dec 4, 2019, 10:01 PM Ravi Pokala wrote: > -----Original Message----- > From: on behalf of Alexander Motin > > Date: 2019-12-04, Wednesday at 20:52 > To: , , < > svn-src-head@freebsd.org> > Subject: svn commit: r355412 - head/sys/geom > > Author: mav > Date: Thu Dec 5 04:52:19 2019 > New Revision: 355412 > URL: https://svnweb.freebsd.org/changeset/base/355412 > > Log: > Wrap g_trace() into a macro to avoid unneeded calls. > > In most cases with debug disabled this function does nothing, but > argument > passing and the call still cost measurable time due to cache misses, > etc. > > Hi Alexander, > > I'm having trouble understanding this change, on a few levels. > > - Why did you add parentheses around the function declaration and > definition? > To prevent macro expansion. - How can that function with that name co-exist with a macro of the same > name? > See above. - Isn't the "g_debugflags" test in geom_dump.c:g_trace() now redundant? > I think so... - Why not simply convert geom_dump.c:g_trace() into a 'static inline' in > geom.h, and not have to bother with the macro at all? > I'd have done that :) you wouldn't have that weird (corner) of the language exposed... but the static inline might have been bigger... Warner What am I missing? > > Thanks, > > Ravi (rpokala@) > > MFC after: 2 weeks > Sponsored by: iXsystems, Inc. > > Modified: > head/sys/geom/geom.h > head/sys/geom/geom_dump.c > > Modified: head/sys/geom/geom.h > > ============================================================================== > --- head/sys/geom/geom.h Thu Dec 5 04:18:22 2019 (r355411) > +++ head/sys/geom/geom.h Thu Dec 5 04:52:19 2019 (r355412) > @@ -255,11 +255,15 @@ void g_dev_physpath_changed(void); > struct g_provider *g_dev_getprovider(struct cdev *dev); > > /* geom_dump.c */ > -void g_trace(int level, const char *, ...); > +void (g_trace)(int level, const char *, ...) __printflike(2, 3); > # define G_T_TOPOLOGY 1 > # define G_T_BIO 2 > # define G_T_ACCESS 4 > - > +extern int g_debugflags; > +#define g_trace(level, fmt, ...) do { \ > + if (__predict_false(g_debugflags & (level))) \ > + (g_trace)(level, fmt, ## __VA_ARGS__); \ > +} while (0) > > /* geom_event.c */ > typedef void g_event_t(void *, int flag); > > Modified: head/sys/geom/geom_dump.c > > ============================================================================== > --- head/sys/geom/geom_dump.c Thu Dec 5 04:18:22 2019 > (r355411) > +++ head/sys/geom/geom_dump.c Thu Dec 5 04:52:19 2019 > (r355412) > @@ -319,7 +319,7 @@ g_confxml(void *p, int flag) > } > > void > -g_trace(int level, const char *fmt, ...) > +(g_trace)(int level, const char *fmt, ...) > { > va_list ap; > > > > >