From owner-freebsd-ports@FreeBSD.ORG Tue Jan 27 08:02:53 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6664516A4CE for ; Tue, 27 Jan 2004 08:02:53 -0800 (PST) Received: from outpost.globcon.net (outpost.globcon.net [62.141.88.161]) by mx1.FreeBSD.org (Postfix) with SMTP id F135943D69 for ; Tue, 27 Jan 2004 08:02:29 -0800 (PST) (envelope-from sergei@kolobov.com) Received: (qmail 40789 invoked from network); 27 Jan 2004 16:02:30 -0000 Received: from agdcgw01.akingump.com (HELO kolobov.com) (12.40.174.2) by outpost.globcon.net (62.141.88.161) with SMTP; 27 Jan 2004 16:02:30 -0000 Received: (qmail 1535 invoked by uid 911); 27 Jan 2004 16:02:04 -0000 Date: Tue, 27 Jan 2004 19:02:04 +0300 From: Sergei Kolobov To: Joe Marcus Clarke Message-ID: <20040127160204.GA704@chetwood.ru> Mail-Followup-To: Joe Marcus Clarke , freebsd-ports@FreeBSD.org References: <1075068827.93327.13.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: <1075068827.93327.13.camel@shumai.marcuscom.com> User-Agent: Mutt/1.5.3i cc: freebsd-ports@FreeBSD.org Subject: Re: ports/49955: [PATCH] bsd.port.mk: add target to automatically install port documentation X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2004 16:02:53 -0000 --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline (cc'd to ports@ to get a broader feedback) On 2004-01-25 at 17:13 -0500, Joe Marcus Clarke wrote: > Was this taken care of in eik's PORTDOCS work? No - PORTDOCS was created with a different goal, I think. To summarize: PORTDOCS dramatically reduces pkg-plist size in case there are a lot of files and/or subdirs under DOCSDIR. For example, PORTDOCS=*. My patch (let's call it DOCS) is for far more common scenario (in my experience, at least) - there are just a few docs files which could (and should) be listed explicitly. I just had an idea how this two approaches be combined into single framework: Ports that have few doc files get this: DOCS= file1 file2 subdir/file3 Ports that have a lot of doc files could use this (renamed from PORTDOCS[1]): DOCS_GLOB= * In both cases, you have a knob to control what's bsd.port.mk does for you automatically: USE_DOCS= yes # Does everything (see below) USE_DOCS= plist # Only adds docs to final pkg-plist USE_DOCS= install # Only installs files to ${DOCSDIR}, # you will need to list the files in pkg-plist # explicitly USE_DOCS= all # Alias to USE_DOCS=yes Then, USE_DOCS=yes could be made a default if DOCS or DOCS_GLOB is defined: .if defined(DOCS) || defined(DOCS_GLOB) USE_DOCS?= yes .endif If this approach is feasible, I'll submit a patch. Sergei [1] I think DOCS is a better variable name than PORTDOCS: DOCS is in line with MAN1 - MAN9, INFO, etc. We all know it's a variable is inside port's Makefile, so "PORT" prefix is kind of superfluous (sp?). --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (FreeBSD) iD8DBQFAFot8FOxuaTulNAERAqGhAJ4/dVDoEK15en2ZKmB/iyMhqCdmkQCfQJRU Iq+PBZmTApgAXN1pCbrQuB8= =EdvK -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--