From owner-svn-src-all@freebsd.org  Wed Jul 29 15:05:49 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C110B9AE7AB;
 Wed, 29 Jul 2015 15:05:49 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 48E681501;
 Wed, 29 Jul 2015 15:05:48 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t6TF5it1006709
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 29 Jul 2015 18:05:45 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t6TF5ijE006706;
 Wed, 29 Jul 2015 18:05:44 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 29 Jul 2015 18:05:44 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Ermal =?iso-8859-1?Q?Lu=E7i?= <eri@freebsd.org>
Cc: Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= <olivier@cochard.me>,
 src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r285051 - head/sys/netinet
Message-ID: <20150729150544.GM97401@FreeBSD.org>
References: <201507021810.t62IAgCc003272@repo.freebsd.org>
 <20150728124220.GW72729@FreeBSD.org>
 <CAPBZQG3owDM4y4noEa9S044MPuw89QZnkG6Ne7y94iBERp37Pg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAPBZQG3owDM4y4noEa9S044MPuw89QZnkG6Ne7y94iBERp37Pg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2015 15:05:49 -0000

  Ermal,

On Wed, Jul 29, 2015 at 03:00:59PM +0200, Ermal Luçi wrote:
E> > E> @@ -934,6 +950,7 @@ ip_forward(struct mbuf *m, int srcrt)
E> > E>       */
E> > E>      if (!srcrt && ia == NULL) {
E> > E>              icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_HOST, 0, 0);
E> > E> +            RO_RTFREE(&ro);
E> > E>              return;
E> > E>      }
E> >
E> > Here the ifa reference is leaked upon return.
E> >
E> >
E> Gleb,
E> 
E> the improvement on the ifa_ref not needed is something to look at but the
E> ifa_ref here is not lost since ia == NULL, no?
E> Maybe i am missing something else.

Sure you are right. Mea culpa.

E> Also can we put this on a review?

It is possible. Let's just wait for Olivier to return and ask him to
do a benchmark :)

-- 
Totus tuus, Glebius.