From owner-cvs-ports@FreeBSD.ORG Thu Sep 30 12:21:08 2010 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 112C21065672; Thu, 30 Sep 2010 12:21:08 +0000 (UTC) (envelope-from decke@FreeBSD.org) Received: from mail.itac.at (mail.itac.at [91.205.172.9]) by mx1.freebsd.org (Postfix) with ESMTP id 7A8BE8FC1A; Thu, 30 Sep 2010 12:21:07 +0000 (UTC) Received: from [91.205.172.21] (helo=secure.bluelife.at) by mail.itac.at with esmtpa (Exim 4.63) (envelope-from ) id 1P1HYx-0000i3-Ky; Thu, 30 Sep 2010 13:44:35 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Date: Thu, 30 Sep 2010 11:44:36 +0000 From: Bernhard Froehlich To: Stanislav Sedov In-Reply-To: <20100930021101.26c36286.stas@FreeBSD.org> References: <201009291312.o8TDCTwo029078@repoman.freebsd.org> <20100929165421.70c8064a.stas@FreeBSD.org> <4CA4505F.1080306@FreeBSD.org> <20100930021101.26c36286.stas@FreeBSD.org> Message-ID: <6d5fc03b56f03828baca44f21e4dd04f@bluelife.at> X-Sender: decke@FreeBSD.org User-Agent: Roundcube Webmail/0.4 X-Spam-Score: -1.0 (-) X-Spam-Report: Spam detection software, running on the system "mail.itac.at", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Thu, 30 Sep 2010 02:11:01 -0700, Stanislav Sedov wrote: > On Thu, 30 Sep 2010 10:54:55 +0200 > Pav Lucistnik mentioned: > >> > >> > It's usually beneficial if you also provide the short changelog of changes >> > in the software, or at least a link to the changelog. Especially in this >> > case, when maintainer wrote it clearly in the PR. >> >> It's not an usual practice. >> > > Unfortunately. But it's a good one to follow, and we used to do this some > time ago. [...] Content analysis details: (-1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.4 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.4 AWL AWL: From: address is in the auto white-list Cc: cvs-ports@FreeBSD.org, Pav Lucistnik , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/zfsnap Makefile distinfo X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2010 12:21:08 -0000 On Thu, 30 Sep 2010 02:11:01 -0700, Stanislav Sedov wrote: > On Thu, 30 Sep 2010 10:54:55 +0200 > Pav Lucistnik mentioned: > >> > >> > It's usually beneficial if you also provide the short changelog of changes >> > in the software, or at least a link to the changelog. Especially in this >> > case, when maintainer wrote it clearly in the PR. >> >> It's not an usual practice. >> > > Unfortunately. But it's a good one to follow, and we used to do this some > time ago. In this special case it could be beneficial because the submitter is also the author of the project and I couldn't find the changelog anywhere after a short search. Sorry for that. >> Again, it's not a usual practice to have this in the Makefiles so the >> cleanup is understandable. > > I understand the cleanup reason, and actually all hands for this, but > the change should be mentioned in the commit message. Okay, I will also mention such tiny changes in the future. -- Bernhard Froehlich http://www.bluelife.at/