From owner-freebsd-bugs@FreeBSD.ORG Wed Apr 25 22:30:10 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2502E16A402 for ; Wed, 25 Apr 2007 22:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 1515713C46A for ; Wed, 25 Apr 2007 22:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l3PMU9Uw064575 for ; Wed, 25 Apr 2007 22:30:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l3PMU93w064572; Wed, 25 Apr 2007 22:30:09 GMT (envelope-from gnats) Date: Wed, 25 Apr 2007 22:30:09 GMT Message-Id: <200704252230.l3PMU93w064572@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Chris Cc: Subject: Re: bin/112126: [patch] netstat(1) segfaults on unusual ICMP statistics X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Chris List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2007 22:30:10 -0000 The following reply was made to PR bin/112126; it has been noted by GNATS. From: Chris To: bug-followup@FreeBSD.org, Maxim Konovalov Cc: Subject: Re: bin/112126: [patch] netstat(1) segfaults on unusual ICMP statistics Date: Thu, 26 Apr 2007 00:00:36 +0200 Hello, postcriptum - I overlooked one detail of Maxim's patch: > +static const char *icmpnames[ICMP_MAXTYPE + 1] = { with this he actually avoids the crash in case of an out of sync kernel interface (assumed the array gets automatically zeroed at allocation time - does it ? ) But this still produces a very funny netstat output with just numbers and no labels. I continue to prefer my suggestion. Regards Christoph Weber-Fahr