From nobody Sat Aug 20 22:07:39 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M9CRV1hsGz4ZQJ0; Sat, 20 Aug 2022 22:07:50 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M9CRT0LcNz41B3; Sat, 20 Aug 2022 22:07:48 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from smtpclient.apple (ip1f100e7e.dynamic.kabel-deutschland.de [31.16.14.126]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 3375F7220BFAF; Sun, 21 Aug 2022 00:07:42 +0200 (CEST) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 8338690a0a43 - main - ip_reass: provide sysctl MIB returning IP fragment TTL From: Michael Tuexen In-Reply-To: <202208202041.27KKfe9e061428@gitrepo.freebsd.org> Date: Sun, 21 Aug 2022 00:07:39 +0200 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202208202041.27KKfe9e061428@gitrepo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4M9CRT0LcNz41B3 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of michael.tuexen@macmic.franken.de has no SPF policy when checking 193.175.24.27) smtp.mailfrom=michael.tuexen@macmic.franken.de X-Spamd-Result: default: False [-1.70 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[193.175.24.27:from]; RCPT_COUNT_THREE(0.00)[4]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:680, ipnet:193.174.0.0/15, country:DE]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; DMARC_NA(0.00)[franken.de]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[] X-ThisMailContainsUnwantedMimeParts: N > On 20. Aug 2022, at 22:41, Gleb Smirnoff wrote: >=20 > The branch main has been updated by glebius: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D8338690a0a43c8b11a382e2160f8eedb= 9aeecf91 >=20 > commit 8338690a0a43c8b11a382e2160f8eedb9aeecf91 > Author: Gleb Smirnoff > AuthorDate: 2022-08-20 20:33:39 +0000 > Commit: Gleb Smirnoff > CommitDate: 2022-08-20 20:39:12 +0000 >=20 > ip_reass: provide sysctl MIB returning IP fragment TTL >=20 > For now it is read-only, but eventually the cycle that goes over > all fragments should be refactored and this MIB should also become > read/write. >=20 > This MIB will allow SNMP daemons to implement MIB-II ipReasmTimeout = MIB > straightfoward. Right now net-snmp compilation is broken by = 1922eb3e9c2. > The base system bsnmpd is not broken just because it ignored = PR_SLOWTIMO, > and thus always returned incorrectly doubled value for = ipReasmTimeout. > --- > sys/netinet/ip_reass.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/sys/netinet/ip_reass.c b/sys/netinet/ip_reass.c > index 0420091e0a2a..e581e2e622c7 100644 > --- a/sys/netinet/ip_reass.c > +++ b/sys/netinet/ip_reass.c > @@ -167,6 +167,10 @@ SYSCTL_PROC(_net_inet_ip, OID_AUTO, = maxfragbucketsize, > sysctl_maxfragbucketsize, "I", > "Maximum number of IPv4 fragment reassembly queue entries per = bucket"); >=20 > +static u_int ipfragttl =3D IPFRAGTTL / 2; > +SYSCTL_UINT(_net_inet_ip, OID_AUTO, fragttl, CTLFLAG_RD, &ipfragttl, > + IPFRAGTTL / 2, "IP fragment life time on reassembly queue"); What unit is used? seconds? milliseconds? You might want to state that. What us the semantic of IPFRAGTTL? What is the unit of that constant? Best regards Michael > + > /* > * Take incoming datagram fragment and try to reassemble it into > * whole datagram. If the argument is the first fragment or one