From nobody Sun Aug 21 04:05:05 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M9MMs0rLKz4b6LC; Sun, 21 Aug 2022 04:05:13 +0000 (UTC) (envelope-from peterj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M9MMr5BYzz3RnY; Sun, 21 Aug 2022 04:05:12 +0000 (UTC) (envelope-from peterj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661054712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=38A3DELaEAES8qjh5xuWh2A5MOaClcQVEPVDfL8ZIiw=; b=p87+1SoLWG0o7FfuojrcfxkGKBZJ9Z1D7g9uIo/dH7S8XYHDx+VGUVhoP2+sbzPNNJRnm8 7zvqqFBZxWK+cNj54l6t3upsLV1VNbSrS/C/fAdFS21HR81rIQKty68FtytsZ4SqnWsLNU dNBjsSTeQsfGkDL3xDn2nLLzX4qQAAlOyc1jPYAop6CfNF5LK4MtsnvzEExHWvqEOmU+Vz l/2E251BQqKjZLE8L6pptoyBp4Q+G3bSO+MWAAhQqxzQhLGhzYNDdIO4zEgqK+sf6+hA2O 4IHCpk7+EJTZCc83ecLQduj8aREdduCXPPixJ9crmtGlXaayGlrCTDxCYYUThg== Received: from server.rulingia.com (ppp239-208.static.internode.on.net [59.167.239.208]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) (Authenticated sender: peterj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4M9MMq1tPxztHl; Sun, 21 Aug 2022 04:05:11 +0000 (UTC) (envelope-from peterj@freebsd.org) Date: Sun, 21 Aug 2022 14:05:05 +1000 From: Peter Jeremy To: Ganbold Tsagaankhuu Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 901df07a4768 - main - Code refactoring for existing rk_gpio driver. It supports gpio type checking. Depending on gpio type some register addresses are different. Message-ID: References: <202208191322.27JDMv0b007432@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oB64sfg/x42kUbgQ" Content-Disposition: inline In-Reply-To: <202208191322.27JDMv0b007432@gitrepo.freebsd.org> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661054712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=38A3DELaEAES8qjh5xuWh2A5MOaClcQVEPVDfL8ZIiw=; b=nYvMA6RONnMeW82JzTTKtNXFgECmWX3zDYXNker6bPLD+REiVR2KgZvPKyIk3E/wsKEyA0 GxbvmTK8MtoWb8fA1LgRR2/a52eCrGELFXoJ+rv4PVs5mGc5k/P1nLZVhf2YB2PaV1bGS9 EdFxbgKRHwmzUCUm1VAuUGc3mRz/iBgnEtPan4fI7OYGq+h4NyJ9wwSw9jkNDu719JMC1y qLpEqeadet0EcAFewO/+liO6karFpnAU/b0YtsXAFG8UfbNTfgJrjwlyaMAN7Tuke/5Y0J cTC8uIHPqLfl8rqUPZiLRm3UKCoozTUzedufcdiLmYlA3rbqTmwT9hvLN3gLFQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661054712; a=rsa-sha256; cv=none; b=udfuuPWN15WbZbjjDUuVbB7O+5PwdtIkWfSyzUCQUTeghwQt8n5qmUXGgy1utlDVniR+jF Sf2ONLx62FmspbCOF9qOavfLsvXgPIUiycW0S6DSZzXm94vQej92KgZ2jerwZe3u+rdS1+ K+HnGjVNMaXFa2JRP3hBtXBr/ipCnfOuFtDiV05tSXXp+RrCNO0Cql+IC/LxHgu5B8wWr2 ZJf0ka/Ryo52P63RdhRW8YbTg4w7wVBhzcqFl9eqoDWCaGjMyuJQ64Jdp/W4NS9Ef/otPu a7Bx37cr7XJmzt8afzsrUjyrHsJjeymeEtdmu4hnjfw3g85944gCpMK4KcC3/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --oB64sfg/x42kUbgQ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2022-Aug-19 13:22:57 +0000, Ganbold Tsagaankhuu wr= ote: >The branch main has been updated by ganbold: > >URL: https://cgit.FreeBSD.org/src/commit/?id=3D901df07a47684dca7b06f60d838= a56456d751a23 > >commit 901df07a47684dca7b06f60d838a56456d751a23 >Author: S=F8ren Schmidt >AuthorDate: 2022-08-19 13:22:01 +0000 >Commit: Ganbold Tsagaankhuu >CommitDate: 2022-08-19 13:22:01 +0000 > > Code refactoring for existing rk_gpio driver. > It supports gpio type checking. Depending on gpio type some > register addresses are different. > =20 > Reviewed by: manu > Differential Revision: https://reviews.freebsd.org/D36262 My Rock64 is now hanging on boot as follows: rk_pinctrl0: on ofwbus0 gpio0: mem 0xff210000-0xff2100ff irq 53 on = rk_pinctrl0 gpio0: Unknown gpio version 48000000 <> >@@ -170,6 +221,43 @@ rk_gpio_attach(device_t dev) > rk_gpio_detach(dev); > return (ENXIO); > } >+ RK_GPIO_LOCK(sc); >+ sc->version =3D rk_gpio_read_4(sc, RK_GPIO_VERSION); >+ RK_GPIO_UNLOCK(sc); This call to rk_gpio_read_4() looks wrong: a) rk_gpio_read_4() tests sc->version which this call is setting. b) The second argument to rk_gpio_read_4() is a "enum gpio_regs", not an actual offset - RK_GPIO_VERSION (=3D0x78) is way outside the sc->regs array. c) sc->regs is also uninitialised at this point. Maybe this should call RK_GPIO_READ() instead, but neither my RK3328 TRM (revision 1.2 from July 2017) nor my RK3399 TRM (revision 1.4 from April 2017) document a GPIO register at offset 0x78 - both only go to 0x60. (If you have a later TRM for either chip, I would be interested in a copy). --=20 Peter Jeremy --oB64sfg/x42kUbgQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmMBrutfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzTV2w//YNj3ms/689BX2nuQxGVN88RDNrMNE88p9jmVoZjK5cSTf1S6/AS1ijgj WoyozC/tz4Bhaiygb3K4zaoXqoDmsvkuV899UPj0ECLA7UywbCImqkefVWf1hytP Fc6l+I+JgCpRc1pErJLLMZsrssEG8TE3fFmhzD0mcXtZNcJ9HDC8sigoHgq4s3Vi sfwxGaqih2JLBQjaS0W/7zIhuumrKwsnaMjvzn75CSrNqtgZJHugOslCrTRz+Vut mfeAzmdlBan2v74XxEbgZrskSxSUIFdBMZDAAYByr1nLzjDBURuH6Hj+ZKLn6NkH Yzf468TVbZH5IkBRIT9KLtbMEoGxqyyNKuDdEmd2m83XUoEpFdX7ZT18KaKbTr81 fPqXE8vqlVoPeI2BQcp7eHbkJ52CG9Z+MYEcL9jxFV3umc6xTmbTnhtphSgCYNvN +nGQqzlnI2ym+hyMSCZjUJ3leJKcYeDbq00xc/5E8rV3Ylu+J+mB9SE/n+3AX3PS 8EQp/Sok86OLjbGPNJqoAXnyNrdrrIsleYC5I/qNcJpnAqHfyWQngsvk4IITiFqd bgIh0+oqwtGy7yb9F2Qk3mOVoOwGiJJGAwu/Pi476Grgtax1s/0UTQChqEYEt3sx B4pt8QehZvKSpCckXMiw1x3mx7tDHXpVh5H/WCWMGA7C3FwjGDs= =ytU4 -----END PGP SIGNATURE----- --oB64sfg/x42kUbgQ--