From owner-freebsd-bugs@FreeBSD.ORG Mon Mar 12 21:30:20 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 146331065670 for ; Mon, 12 Mar 2012 21:30:20 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F301B8FC1D for ; Mon, 12 Mar 2012 21:30:19 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2CLUJGI054551 for ; Mon, 12 Mar 2012 21:30:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2CLUJPt054546; Mon, 12 Mar 2012 21:30:19 GMT (envelope-from gnats) Date: Mon, 12 Mar 2012 21:30:19 GMT Message-Id: <201203122130.q2CLUJPt054546@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Ed Schouten Cc: Subject: Re: bin/143017: watch(8): fatal: cannot attach to tty X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ed Schouten List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2012 21:30:20 -0000 The following reply was made to PR bin/143017; it has been noted by GNATS. From: Ed Schouten To: Mark Johnston Cc: bug-followup@freebsd.org, dummy@smtp.ru Subject: Re: bin/143017: watch(8): fatal: cannot attach to tty Date: Mon, 12 Mar 2012 22:27:25 +0100 --gTY1JhLGodeuSBqf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Mark Johnston , 20120312 22:17: > Oh, I was referring to the -i flag; my comment was misleading, sorry. > opt_interactive (or something similar) is still needed in order for > watch(8) to work properly when writing output to a file, no? Sure, but in that case you can simply use isatty() to distinguish the special treatment. What I mean is that you can only call watch(8) by passing the TTY used on the command line. Also I see you've simplified the code that dynamically scales the input buffer size. Though I think that's a good idea, I do think we should increase BUF_SIZE to something higher. Setting it to 4 KB or something shouldn't harm, right? --=20 Ed Schouten WWW: http://80386.nl/ --gTY1JhLGodeuSBqf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iQIcBAEBAgAGBQJPXmo9AAoJEG5e2P40kaK7OzYP/19abRoyvfYM7KbPpV88P/B5 oOOzD4xnfPzdHy5HTkoDz8UyS0nwZEhxLwVOHRxyOhmr+6EJ5Wc+aU2B/kMWUWTX KQMVzvND0jq867MNv/p/tQp0PvQBfebG/jp/uNcHV8KtNPRMneEKR6o02wDaj2kQ Y+e2QVe0H+SolAJHKxOpy5L5p/A282bL7Tjc6yGq1RTh3OF22jPyRcdmB3Dchgwh OjmDzu2F2g8+K0vGNiDBI1q8ZzSQ1OHy42GkDkRStakPh4yCyT430B8sRr2DOhYw U3FCRx15qpfFXPsh+rYH3JaqKLw5K+ewWDpXw61eNFz2FQuavwiqi1gM8+KqWeDJ u+PchWtAScQ+Y4oJUpmJgia/GHCncvWaQ0K0aG35PuBagnDS0CzXz5qHhEI5rqiA ENQPeelwz/BWnvFfnkZdIDYA5rwndlrDGw7lXjGLsyH4PYVegtmqXcHUVgYAEpnG D1mElDHCuc2RY5z3s3rt/T5Z6W3j+awhwLxsc0V7wrDKp627Ly23v6pqnmk1dw4m SDZUPj39R1eRHE82+dtX4fKWLtAl2k8P2rPz1+lzre82fqDzk7hHw93iuDW0PpvL sU5Uy4UxHGQsIaaGadiiJEfVeMMFJoQUVrCpymz3VJt6h4Ro7+MC1wbjcyjnddLu 3+ieINfse6iLxIE760I/ =qWD5 -----END PGP SIGNATURE----- --gTY1JhLGodeuSBqf--