From owner-svn-ports-all@FreeBSD.ORG Tue Oct 15 06:52:32 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2483E6F for ; Tue, 15 Oct 2013 06:52:32 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D247D26EA for ; Tue, 15 Oct 2013 06:52:31 +0000 (UTC) Received: by mail-vc0-f171.google.com with SMTP id lf12so156401vcb.2 for ; Mon, 14 Oct 2013 23:52:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=fAtEFzIibX+aaY0odc1EOo7dG+Yrw1sgNaR+PLkT4qY=; b=GnFcHk0V8FZQglJFSXZWV1gbxIYXJ7p0or4heydvMbwiSLgajWS2jQ6d1CRwYslLAT gCZaPfm5DMF4wcxLkhfah3YtGegZP1UqmSSnGyFj0O6XTZt8Sa2ROxec8/BjBMGmZzbU N+oSnsXBE40ECr3oBusp8+IZJYhSUgnv4wcI+HTZlJasnp+3TqhxpMt36Ksug9eGtLLP h5GMcRXmYjCeCvyNs04zR7fb5Y/lZkxgkJu5LdKZTZSAWMn3c4YI6rJ3HUBo7+K6qDfM OwRRPUTul0mFYFnH3qFnC2Tmi2kpJRU5o+XAbPI9OBvh0eTCFHy7/Q/9/YVWtaLsugFe oTRw== X-Gm-Message-State: ALoCoQlL/Bm8ZnROwLyASrtIARZcYFHTjzM6eAOvM+ODu8E6lKSjk8qDWE1vdxAusghnteBSdco1 MIME-Version: 1.0 X-Received: by 10.220.74.69 with SMTP id t5mr188261vcj.18.1381819945495; Mon, 14 Oct 2013 23:52:25 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.52.34.205 with HTTP; Mon, 14 Oct 2013 23:52:25 -0700 (PDT) In-Reply-To: <7325bc9d-a492-4b96-b9dc-3a3f8ecbcf3b.maildroid@localhost> References: <201310100009.r9A09Zah023159@svn.freebsd.org> <7325bc9d-a492-4b96-b9dc-3a3f8ecbcf3b.maildroid@localhost> Date: Mon, 14 Oct 2013 23:52:25 -0700 X-Google-Sender-Auth: RSYELGUXNseJYAjaRbxYKzCA3BU Message-ID: Subject: Re: svn commit: r329946 - in head/databases: postgresql84-client postgresql84-contrib postgresql84-docs postgresql84-server postgresql90-client postgresql90-contrib postgresql90-docs postgresql90-plper... From: Jason Helfman To: Chris Rees Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , ports-committers , Jason Helfman , Sunpoet Po-Chuan Hsieh , "pgsql@FreeBSD.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 06:52:32 -0000 Looks good to me, as well, and approved. The port was highly reliant on PKGNAMESUFFIX changing before, however this is no longer the case. Thanks! -jgh On Sat, Oct 12, 2013 at 12:09 PM, Chris Rees wrote: > Looks fine to me, if Jason approves. > > Thanks also for the Python changes. > > Chris > > > > -----Original Message----- > From: Sunpoet Po-Chuan Hsieh > To: Jason Helfman , pgsql@freebsd.org > Cc: ports-committers , > svn-ports-all@freebsd.org, svn-ports-head@freebsd.org > Sent: Sat, 12 Oct 2013 19:55 > Subject: Re: svn commit: r329946 - in head/databases: postgresql84-client > postgresql84-contrib postgresql84-docs postgresql84-server > postgresql90-client postgresql90-contrib postgresql90-docs > postgresql90-plper... > > Hi Jason and pgsql@ team, > > May I suggest to remove DISTV as it's only used in PKGNAMESUFFIX and > portlint complains [1]. > I have prepared a patch [2] which contains 2 changes: > 1) PKGNAMESUFFIX?=${DISTVERSION:R:S/.//}${COMPONENT} > 2) Convert to new LIB_DEPENDS format for postgresql*-contrib ports > I have also checked PKGNAME is unchanged after applying this patch. > Please review it. > Thanks. > > [1] FATAL: Makefile: extra item "DISTV" placed in the PORTNAME section. > [2] http://people.freebsd.org/~sunpoet/postgresql-pkgname.patch > > Regards, > sunpoet > > -- > This message has been scanned for viruses and > dangerous content by MailScanner, and is > believed to be clean. > > > -- > This message has been scanned for viruses and > dangerous content by MailScanner, and is > believed to be clean. > > -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve