From owner-freebsd-bugs@FreeBSD.ORG  Wed Jan  6 18:40:08 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EE151106568B
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  6 Jan 2010 18:40:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id DD9088FC16
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  6 Jan 2010 18:40:08 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o06Ie8Wn064570
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 6 Jan 2010 18:40:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o06Ie8B3064569;
	Wed, 6 Jan 2010 18:40:08 GMT (envelope-from gnats)
Date: Wed, 6 Jan 2010 18:40:08 GMT
Message-Id: <201001061840.o06Ie8B3064569@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Antoine Brodin <antoine@FreeBSD.org>
Cc: 
Subject: Re: bin/142384: sync fsck_msdosfs with OpenBSD
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Antoine Brodin <antoine@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jan 2010 18:40:09 -0000

The following reply was made to PR bin/142384; it has been noted by GNATS.

From: Antoine Brodin <antoine@FreeBSD.org>
To: "Pedro F. Giffuni" <giffunip@tutopia.com>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/142384: sync fsck_msdosfs with OpenBSD
Date: Wed, 6 Jan 2010 19:38:06 +0100

 On Wed, Jan 6, 2010 at 7:05 PM, Pedro F. Giffuni <giffunip@tutopia.com> wrote:
 >> This does not look right, you probably want:
 >> if ((n = read(dosfs, block, sizeof(block))) == -1 || n != sizeof(block))
 >>
 >
 > Hmm... It was taken as-is from OpenBSD's CVS
 >
 > http://www.openbsd.org/cgi-bin/cvsweb/src/sbin/fsck_msdos/boot.c.diff?r1=1.12;r2=1.13
 >
 > but I have no objection with adding the parenthesis.
 
 My problem was with the parenthesis between "n=" and "read" in your patch.
 
 Cheers,
 
 Antoine