From owner-cvs-all Wed Jan 9 18:14: 0 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id DA96F37B402; Wed, 9 Jan 2002 18:13:51 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id g0A2Dc308736; Wed, 9 Jan 2002 21:13:38 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: References: Date: Wed, 9 Jan 2002 21:13:37 -0500 To: Daniel Eischen , Will Andrews From: Garance A Drosihn Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c Cc: David Malone , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.1 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 8:09 PM -0500 1/9/02, Daniel Eischen wrote: >On Wed, 9 Jan 2002, Will Andrews wrote: >> On Wed, Jan 09, 2002 at 05:26:40PM -0500, Daniel Eischen wrote: >> > Doesn't everyone add -Wall to (and enable) CFLAGS in /etc/make.conf, >> > or am I one of the few? >> >> Do you ever compile ports? > >Sure, not a whole lot, but I do use the ports tree. I've never >had -Wall abort a port build. I consider our ports tree a separate >thing anyways. We should have higher standards for the code in >our own source tree. I think everyone making changes in src should >be compiling with -Wall. I think "we" (he says vaguely) are trying to use the NOWARNS setting to indicate what level of warnings we want, and let *it* put things like -Wall into CFLAGS. There's also some environment/MAKE variable to use so compiles don't die if they get a compile-time warning. In my case, I tend to compile with BDECFLAGS (skipping NOWARN :-) on anything where I am making changes to the source, but I leave the global settings the way "the project" uses them. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message