From owner-svn-src-head@freebsd.org Thu May 17 19:33:12 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6DF4EEDE619 for ; Thu, 17 May 2018 19:33:12 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic312-21.consmr.mail.bf2.yahoo.com (sonic312-21.consmr.mail.bf2.yahoo.com [74.6.128.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 135BB72DED for ; Thu, 17 May 2018 19:33:11 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1526585585; bh=BsIGUlxy1Ii976a9Rm46zhbkE+10byN4JHCPkbaq+NI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=acxoMpBdLoXD0egmOwCdloIi80+BjSJnxp5SfgTBw+IztvzkNy6RFz4doEloy7X41RZYKymF/f3GdzKqZx+baYdmPpXBanWq6ACUfNE4hdOVsNRT+g+qjrOVwQRcVnSDdKmxMuomdjUX+b4YaCQIC9h+ZyCY7lMVOZIf9GtEdGVSz/pr7ppBQ+3tdi1u419E6uuClacZ9uMUmjYIFc8NxYNDZ0i1imAflGVf25YbJk7oYjq8SvpHGjSU0GNilIVvo1xdBZ7XhN2N33KW+3B4+XuZ8HgiFQUSA6rIy0/KAQNLjslam2jnG0dV9000FE/Xag1rl1Lbo4HlgWqe4NxWog== X-YMail-OSG: iQwq2qQVM1nnwrjozr1fd4rVvLQjB1ls8jUx13vGybZE.daobceGt0HyfdcE4AH pzhbuC7IBRxxhdSizqzllLhEdk50dr5ZJRb4dkS6TdhTuF_ECYex4MVpahAgiXl.tkt0lxF285JW _tXftQBoO3taG03O4TuwhQuw5aHdMnTYqzrt65C6X4US0t1RJpHrwM8.jmn25qZFc3T9XmMmiP5O AFg_7JIbOoztdl_UkmHoBuhKQ92WdEPsBgflCT4lSS_OB0_DU2VmtezB_0UqkDT4BFFXTvjBWvoL FoWZVPtQH2JALx2atfsp79Sm5UFAqIaECntZllj2oz_INoo9STcK8p3g709HR6rS0qfFIz7fEx6y q9NxBPa4J9ZkcYmwmgejwnk17C4dGPv9vY8AxNxmlzTxlEpvgr1Oc2EANTHAFkg9136Buq3k6FZN Ly6V0w47RWzugCQvvpwDcEwOSX9ruug0ZSFEetBA4if7S5fpdJv0YktGmQ36eSPtkRCAB7AR_wSO 6AdudH30Gz8OkaiczSOH6qat9lxAkm47T_IbLgaOKJu664nbAnRJRQ1TcrZH.JkEg5EdRzDs3dCz 0e6c5gJenq7Pr_jH5d2u0DDWGxqU.aN33OTFspMs22YLJlox2z_bNJ81y5Kof3_yGl3A- Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.bf2.yahoo.com with HTTP; Thu, 17 May 2018 19:33:05 +0000 Received: from 181.52.72.201 (EHLO [192.168.0.6]) ([181.52.72.201]) by smtp423.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 59b9777c142b81727a93f8a784cb72d8; Thu, 17 May 2018 19:33:00 +0000 (UTC) Subject: Re: svn commit: r333745 - in head/sys/contrib/ck: include src To: Emmanuel Vadot Cc: Matthew Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201805171814.w4HIEA0F079835@repo.freebsd.org> <20180517203856.aa6b8b241e23b9c07483232b@bidouilliste.com> <17058056-6b70-e918-dab8-63951d1bfbbd@FreeBSD.org> <20180517212757.84c7b02060ca8f86e56dbee9@bidouilliste.com> From: Pedro Giffuni Organization: FreeBSD Project Message-ID: <11fb642a-d334-bd7d-be4f-b1aa181b8eb2@FreeBSD.org> Date: Thu, 17 May 2018 14:32:58 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180517212757.84c7b02060ca8f86e56dbee9@bidouilliste.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 19:33:12 -0000 On 17/05/2018 14:27, Emmanuel Vadot wrote: > On Thu, 17 May 2018 14:20:05 -0500 > Pedro Giffuni wrote: > >> On 17/05/2018 14:12, Matthew Macy wrote: >>> How do I avoid problems while allowing timely updates? >>> >>> -M >>> >>> On Thu, May 17, 2018 at 11:38 AM, Emmanuel Vadot wrote: >>>> Hi Matt, >>>> >>>> On Thu, 17 May 2018 18:14:10 +0000 (UTC) >>>> Matt Macy wrote: >>>> >>>>> Author: mmacy >>>>> Date: Thu May 17 18:14:10 2018 >>>>> New Revision: 333745 >>>>> URL: https://svnweb.freebsd.org/changeset/base/333745 >>>>> >>>>> Log: >>>>> ck: add support for executing callbacks outside of main poll loop >>>>> >>>>> Pull in change from upstream deca119d14bfffd440770eb67cbdbeaf7b57eb7b >>>>> >>>>> | ck_epoch: introduce ck_epoch_deferred >>>>> | >>>>> | Allow for deferral to occur outside epoch poll critical loop (which may access per-CPU structures). >>>>> | >>>>> >>>>> Approved by: sbruno >>>>> >>>>> Modified: >>>>> head/sys/contrib/ck/include/ck_epoch.h >>>>> head/sys/contrib/ck/src/ck_epoch.c >>>>> >>>> CK was imported in vendor-sys/ck, commiting directly into head will >>>> cause some problems in the future. >> Actually ... committing to head is fine: some things just have to be fixed. > This is not true, it can cause a lot of problems with futures updates > if the change isn't in the vendor repo. OK ... I meant generally you can. The catch here is that the change was already upstream so it should have been done in the vendor area and then merged. It's best to fix this properly now. Sorry for misguiding. Pedro. >> We do ask you try to upstream the change and re-merge things when possible. > This is already upstream, Matt is just updating CK with a patch he did > ( see > https://github.com/concurrencykit/ck/commit/deca119d14bfffd440770eb67cbdbeaf7b57eb7b) > >> Pedro.