From owner-svn-src-all@FreeBSD.ORG Wed Nov 12 22:19:51 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 01DF438E for ; Wed, 12 Nov 2014 22:19:50 +0000 (UTC) Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BD7E7F9 for ; Wed, 12 Nov 2014 22:19:50 +0000 (UTC) Received: by mail-pa0-f44.google.com with SMTP id bj1so13976816pad.3 for ; Wed, 12 Nov 2014 14:19:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=NQ/KoSTVaWAneMd1DduZzqzl3MLmOTV6DNDQwT6T+TI=; b=V6P077cyTPr9ACEgqFwUSdLSI6rZn1qrlp/VTvw1dq4lyoU+BxnIKe14MYvy2nj/0P M+6JImd88r4DbbZ2LB0vAEIoVNzJvbAbv0cZWpLkdi0K3r8GZFC+m9XOHcXjvqDzKr4n tgCDbBN/yDqgem93XWVX+LDII7xEq+Ciyj17iAUvo/pXIyiQCHjoqkPErWK8cX4AQ3t0 nmXbOzaSVfUbGrMPV3Zn8hFnS6LWEtPNmtXsA3A+rVpSGrTZYffkIwTp4YqZU2EqOVeU o/knpyur7mv9fDNY4GbdBDVMUUUsDE2+gqlgRhq1Ci7SpCrm01SlVXrQ5KANnJGH7DEo OOKw== X-Gm-Message-State: ALoCoQlLU670OSHCdbbPCcDgc6P8oFgyyA7txHwljLwOwWW8uwqV3tLtUXv1pDEiHIt7W+8XnZ/X X-Received: by 10.70.41.232 with SMTP id i8mr49777289pdl.21.1415830784609; Wed, 12 Nov 2014 14:19:44 -0800 (PST) Received: from [10.64.25.121] ([69.53.236.236]) by mx.google.com with ESMTPSA id w16sm22992273pbt.71.2014.11.12.14.19.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 12 Nov 2014 14:19:38 -0800 (PST) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_3EE365D4-6D40-46C0-97F7-C285D2EF28F4"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r274186 - head/share/mk From: Warner Losh In-Reply-To: Date: Wed, 12 Nov 2014 15:19:33 -0700 Message-Id: <66DD8D8B-B1D4-48BC-BC1A-021FE9E7D048@bsdimp.com> References: <201411061719.sA6HJgFu062138@svn.freebsd.org> To: NGie Cooper X-Mailer: Apple Mail (2.1878.6) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Warner Losh , "bdrewery@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2014 22:19:51 -0000 --Apple-Mail=_3EE365D4-6D40-46C0-97F7-C285D2EF28F4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Nov 12, 2014, at 3:07 PM, NGie Cooper wrote: > On Thu, Nov 6, 2014 at 9:21 AM, Garrett Cooper = wrote: >> On Nov 6, 2014, at 9:19, Warner Losh wrote: >>=20 >>> Author: imp >>> Date: Thu Nov 6 17:19:41 2014 >>> New Revision: 274186 >>> URL: https://svnweb.freebsd.org/changeset/base/274186 >>>=20 >>> Log: >>> Ignore errors from rm -rf to support high -j builds. This is, at = best, >>> a kludge. However, it also effectively works around the issues for >>> high -j builds on systems that do not have the rm fixes. >>>=20 >>> A better fix would be to rmdir here, and fix the places where we're >>> sloppy and not list all the files we create in CLEANFILES, should >>> anybody have the time to chase them all to ground. >>=20 >> I=92ll say that bsd.progs.mk is a huge problem here because = CLEANFILES is handled times. >>=20 >> Dealing with bsd.progs.mk and its recursive nature is quite = entertaining... >=20 > Another question related to this commit... >=20 > Why aren't return codes ignored for rm -f ${CLEANFILES} ? Because those don=92t race each other like the directories do. > bdrewery@ ran into an issue at $work where the build failed after > r268376 because he ran into ESTALE with rm: >=20 > 13:51 <@bdrewery> rm: fts_open: Stale NFS file handle That should fail. If you have weird errors, it should fail, this is a = weird error. > This commit will allow the build to continue when dealing with ESTALE > on directories, but it won't fix the case where we hit ESTALE with > CLEANFILES. So? You=92ll hit the failure with CLEANFILES soon enough. But as = mentioned in the commit message, better fixes are possible. I suggest that this has taken = more of my time than is has returned in benefit at this point. Warner --Apple-Mail=_3EE365D4-6D40-46C0-97F7-C285D2EF28F4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUY9z1AAoJEGwc0Sh9sBEAYZQQAKF4Kio6rrWzjKxFBw2QWnQO boo/uS5htf2UwQdS5vdzeMi0Dyo0hbJFXtzcPoUvGYSfJFfWtL2GYwV7ggWi5+yn fV3rrS8V7G/1GyXSpnxu/IM/yvHppXF5dOSGDG5EooegQ3uSXUcLm8w9BktvpH9R f+joPqmJe5kLym/D+AAMOfdyADbH9Ue10ty1FHtALv/qQRMdSXUY5GYDUvsDadhF V+S3p0n+PLFJvYeDRLe96RNTcF2LvcwNDEWnftR5orNsOJzjUlolMonxB/S6SF3U j2PMTQT0itCs03eooK39Zk/jDbJjoRUmE7dgZuSqpLJH35OmzdtPP7iNWPnHVXI9 1qnAAzDztTvbiczmFfr6Gesqg9ZNHf6lULrEd0+u84Hhd/5jLI6oe33LFqtbJje0 3RiFlbwsSUmC/Lo+vZuIgiJ5x5i/6345sekDdETJbbe7iQPNdbDBFZk2V11W3J6Q ZnkMJLXeE34mdxoxVrkj3qB1L2Wqz58WQ4B2uSe/Q93b/uTfID8DoCBZ0xtdAFyq inYYloogygeaui7Jkulc/pAseiFyf57Z5AK43KSeaZ3NJ6nva5k2mQxWdlpYWmFi QXnyDkufk/toGGvWQoo0vcZowchp3Cke1x/CtJo5s94pKXLsHCoAj3zpG456L5DS xbtDSchmcXvYOwLDhTEL =8/CF -----END PGP SIGNATURE----- --Apple-Mail=_3EE365D4-6D40-46C0-97F7-C285D2EF28F4--