Date: Wed, 12 Nov 2014 15:19:33 -0700 From: Warner Losh <imp@bsdimp.com> To: NGie Cooper <yaneurabeya@gmail.com> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Warner Losh <imp@freebsd.org>, "bdrewery@freebsd.org" <bdrewery@freebsd.org> Subject: Re: svn commit: r274186 - head/share/mk Message-ID: <66DD8D8B-B1D4-48BC-BC1A-021FE9E7D048@bsdimp.com> In-Reply-To: <CAGHfRMCGwUb8wQGriaSJYoE4PpH4PXcW7uFJW8WEBNjoucTUiw@mail.gmail.com> References: <201411061719.sA6HJgFu062138@svn.freebsd.org> <D1251D73-0B14-41D5-B2C8-C2D82453CE29@gmail.com> <CAGHfRMCGwUb8wQGriaSJYoE4PpH4PXcW7uFJW8WEBNjoucTUiw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_3EE365D4-6D40-46C0-97F7-C285D2EF28F4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Nov 12, 2014, at 3:07 PM, NGie Cooper <yaneurabeya@gmail.com> wrote: > On Thu, Nov 6, 2014 at 9:21 AM, Garrett Cooper <yaneurabeya@gmail.com> = wrote: >> On Nov 6, 2014, at 9:19, Warner Losh <imp@freebsd.org> wrote: >>=20 >>> Author: imp >>> Date: Thu Nov 6 17:19:41 2014 >>> New Revision: 274186 >>> URL: https://svnweb.freebsd.org/changeset/base/274186 >>>=20 >>> Log: >>> Ignore errors from rm -rf to support high -j builds. This is, at = best, >>> a kludge. However, it also effectively works around the issues for >>> high -j builds on systems that do not have the rm fixes. >>>=20 >>> A better fix would be to rmdir here, and fix the places where we're >>> sloppy and not list all the files we create in CLEANFILES, should >>> anybody have the time to chase them all to ground. >>=20 >> I=92ll say that bsd.progs.mk is a huge problem here because = CLEANFILES is handled <number of PROGS> times. >>=20 >> Dealing with bsd.progs.mk and its recursive nature is quite = entertaining... >=20 > Another question related to this commit... >=20 > Why aren't return codes ignored for rm -f ${CLEANFILES} ? Because those don=92t race each other like the directories do. > bdrewery@ ran into an issue at $work where the build failed after > r268376 because he ran into ESTALE with rm: >=20 > 13:51 <@bdrewery> rm: fts_open: Stale NFS file handle That should fail. If you have weird errors, it should fail, this is a = weird error. > This commit will allow the build to continue when dealing with ESTALE > on directories, but it won't fix the case where we hit ESTALE with > CLEANFILES. So? You=92ll hit the failure with CLEANFILES soon enough. But as = mentioned in the commit message, better fixes are possible. I suggest that this has taken = more of my time than is has returned in benefit at this point. Warner --Apple-Mail=_3EE365D4-6D40-46C0-97F7-C285D2EF28F4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUY9z1AAoJEGwc0Sh9sBEAYZQQAKF4Kio6rrWzjKxFBw2QWnQO boo/uS5htf2UwQdS5vdzeMi0Dyo0hbJFXtzcPoUvGYSfJFfWtL2GYwV7ggWi5+yn fV3rrS8V7G/1GyXSpnxu/IM/yvHppXF5dOSGDG5EooegQ3uSXUcLm8w9BktvpH9R f+joPqmJe5kLym/D+AAMOfdyADbH9Ue10ty1FHtALv/qQRMdSXUY5GYDUvsDadhF V+S3p0n+PLFJvYeDRLe96RNTcF2LvcwNDEWnftR5orNsOJzjUlolMonxB/S6SF3U j2PMTQT0itCs03eooK39Zk/jDbJjoRUmE7dgZuSqpLJH35OmzdtPP7iNWPnHVXI9 1qnAAzDztTvbiczmFfr6Gesqg9ZNHf6lULrEd0+u84Hhd/5jLI6oe33LFqtbJje0 3RiFlbwsSUmC/Lo+vZuIgiJ5x5i/6345sekDdETJbbe7iQPNdbDBFZk2V11W3J6Q ZnkMJLXeE34mdxoxVrkj3qB1L2Wqz58WQ4B2uSe/Q93b/uTfID8DoCBZ0xtdAFyq inYYloogygeaui7Jkulc/pAseiFyf57Z5AK43KSeaZ3NJ6nva5k2mQxWdlpYWmFi QXnyDkufk/toGGvWQoo0vcZowchp3Cke1x/CtJo5s94pKXLsHCoAj3zpG456L5DS xbtDSchmcXvYOwLDhTEL =8/CF -----END PGP SIGNATURE----- --Apple-Mail=_3EE365D4-6D40-46C0-97F7-C285D2EF28F4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?66DD8D8B-B1D4-48BC-BC1A-021FE9E7D048>