From owner-freebsd-fs@FreeBSD.ORG Fri Aug 31 00:06:20 2007 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCEBF16A46B for ; Fri, 31 Aug 2007 00:06:20 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from fallbackmx02.syd.optusnet.com.au (fallbackmx02.syd.optusnet.com.au [211.29.133.72]) by mx1.freebsd.org (Postfix) with ESMTP id D7E4613C468 for ; Fri, 31 Aug 2007 00:06:18 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail06.syd.optusnet.com.au (mail06.syd.optusnet.com.au [211.29.132.187]) by fallbackmx02.syd.optusnet.com.au (8.12.11.20060308/8.12.11) with ESMTP id l7V068Ae006847 for ; Fri, 31 Aug 2007 10:06:08 +1000 Received: from besplex.bde.org (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail06.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l7V00wnx026703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 31 Aug 2007 10:01:07 +1000 Date: Fri, 31 Aug 2007 10:00:58 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Tz-Huan Huang In-Reply-To: <6a7033710708300835n5ac95063o6331ede5fcc80662@mail.gmail.com> Message-ID: <20070831092907.K8647@besplex.bde.org> References: <20070712084115.GA2200@deviant.kiev.zoral.com.ua> <20070716195556.P12807@besplex.bde.org> <20070721063434.GI2200@deviant.kiev.zoral.com.ua> <20070721233613.Q3366@besplex.bde.org> <20070804075730.GP2738@deviant.kiev.zoral.com.ua> <20070808004001.O926@besplex.bde.org> <20070807170259.GJ2738@deviant.kiev.zoral.com.ua> <20070810133946.H769@besplex.bde.org> <20070810124153.GW2738@deviant.kiev.zoral.com.ua> <20070814154812.J24186@besplex.bde.org> <6a7033710708300835n5ac95063o6331ede5fcc80662@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: bugs@freebsd.org, fs@freebsd.org Subject: Re: msdosfs not MPSAFE X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2007 00:06:20 -0000 On Thu, 30 Aug 2007, Tz-Huan Huang wrote: > I have a patch that remove the global variables nambuf_ptr, nambuf_len and > nambuf_last_id entirely. It should be applied on recent 7-current. Please give > it a try, thanks a lot. > > http://w.csie.org/~tzhuan/freebsd/msdosfs.diff This is too late. I just got approval to commit my version mailed here on 10 Aug, and will commit it today. That version also removes the globals, but doesn't change the algorithm so much. Your version seems to be simpler but has too many style bugs for me. If you want to do more work on this, please adjust your patch to apply to the version that I will commit and clean it up. Bruce