Date: Fri, 23 Nov 2001 01:05:45 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Brian Feldman <green@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/include Makefile readpassphrase.h src/lib/libc/gen Makefile.inc getpass.3 getpass.c readpassphrase.3 readpassphrase.c Message-ID: <20011123002720.J17250-100000@delplex.bde.org> In-Reply-To: <20011121171259.A13277@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 21 Nov 2001, Ruslan Ermilov wrote: > On Thu, Nov 22, 2001 at 01:14:55AM +1100, Bruce Evans wrote: > > On Tue, 20 Nov 2001, Brian Feldman wrote: > > > ... > > > Added files: > > > include readpassphrase.h > > > lib/libc/gen readpassphrase.3 readpassphrase.c > > > ... > > This seems to break the threads library, since it is missing the > > FreeBSD changes to getpass.c that changed some syscall names from > > foo to _foo. > > > Hmm. How this can break the threads library if we don't (anymore) > build libc's SRCS with libc_r? Can you please elaborate on this? I should have said that it seems to break linkage with the threads library. The threads library provides special versions of some of the syscalls used in getpass.c/readpassphrase.c, so I was concerned about the wrong versions being used. Checking this shows that there is usually no problem for syscall "foo" provided the application doesn't provide its own function named foo, because the threads library provides both foo and _foo (as does libc). However, getpass.c/readpassphrase.c calls [_]write(), and write() is slightly different from _write() in the threads library. > Also, to get declarations of wrapped syscall names, one should enclose > the file's standard includes into the namespace.h/un-namespace.h > brackets. getpass.c had this. The To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011123002720.J17250-100000>