Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Jun 2011 00:12:54 +1000 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw>
Cc:        src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org, Stefan Farfeleder <stefanf@FreeBSD.org>, Bruce Evans <brde@optusnet.com.au>, Tai-hwa Liang <avatar@FreeBSD.org>
Subject:   Re: svn commit: r223138 - head/sys/ufs/ffs
Message-ID:  <20110617000654.W1926@besplex.bde.org>
In-Reply-To: <1106161923211.44181@www.mmlab.cse.yzu.edu.tw>
References:  <201106160526.p5G5Q3RX013915@svn.freebsd.org> <20110616065310.GA2542@mole.fafoe.narf.at> <20110616175314.R935@besplex.bde.org> <1106161923211.44181@www.mmlab.cse.yzu.edu.tw>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 16 Jun 2011, Tai-hwa Liang wrote:

> On Thu, 16 Jun 2011, Bruce Evans wrote:

>> It might be a style bug (like typedefing a struct) to use enums for
>> anything.  They are impossible to declare opaquely.
>
>  Does that mean we have to #include <sys/vnode.h> in userland 
> makefs/ffs/ffs_bswap.c?

It means that you should implement headers properly, so that they don't
depend on other headers to begin with or grow dependencies on other
headers.  Though the should-be-kernel-only header <sys/vnode.h> has some
parts including `enum vtype' that have already escaped to userland, other
headers shouldn't grow dependencies on these.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110617000654.W1926>