From owner-svn-src-all@FreeBSD.ORG  Thu Jun 16 14:12:58 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 08201106566C;
	Thu, 16 Jun 2011 14:12:58 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail03.syd.optusnet.com.au (mail03.syd.optusnet.com.au
	[211.29.132.184])
	by mx1.freebsd.org (Postfix) with ESMTP id 7B2BC8FC26;
	Thu, 16 Jun 2011 14:12:57 +0000 (UTC)
Received: from c122-106-165-191.carlnfd1.nsw.optusnet.com.au
	(c122-106-165-191.carlnfd1.nsw.optusnet.com.au [122.106.165.191])
	by mail03.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	p5GECsJk012067
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 17 Jun 2011 00:12:55 +1000
Date: Fri, 17 Jun 2011 00:12:54 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw>
In-Reply-To: <1106161923211.44181@www.mmlab.cse.yzu.edu.tw>
Message-ID: <20110617000654.W1926@besplex.bde.org>
References: <201106160526.p5G5Q3RX013915@svn.freebsd.org>
	<20110616065310.GA2542@mole.fafoe.narf.at>
	<20110616175314.R935@besplex.bde.org>
	<1106161923211.44181@www.mmlab.cse.yzu.edu.tw>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
	svn-src-head@FreeBSD.org, Stefan Farfeleder <stefanf@FreeBSD.org>,
	Bruce Evans <brde@optusnet.com.au>, Tai-hwa Liang <avatar@FreeBSD.org>
Subject: Re: svn commit: r223138 - head/sys/ufs/ffs
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2011 14:12:58 -0000

On Thu, 16 Jun 2011, Tai-hwa Liang wrote:

> On Thu, 16 Jun 2011, Bruce Evans wrote:

>> It might be a style bug (like typedefing a struct) to use enums for
>> anything.  They are impossible to declare opaquely.
>
>  Does that mean we have to #include <sys/vnode.h> in userland 
> makefs/ffs/ffs_bswap.c?

It means that you should implement headers properly, so that they don't
depend on other headers to begin with or grow dependencies on other
headers.  Though the should-be-kernel-only header <sys/vnode.h> has some
parts including `enum vtype' that have already escaped to userland, other
headers shouldn't grow dependencies on these.

Bruce