From nobody Tue Jan 6 14:40:27 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dlv3H6FPxz6Nhxk; Tue, 06 Jan 2026 14:40:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dlv3H5l9xz3h1X; Tue, 06 Jan 2026 14:40:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767710427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=49mrQomRWg0kyRZ/J824/keZ64INa/9HtOPW/AAH9co=; b=t+rdklFh/xzn8SvIzJ5oBWgpxjqDc1QhbhU/hCo5ZcZ0iOKDML0DLWCUQOm/XZnfomTlQ3 MXUSNV3VHjXEuPbjqdUr2viAZAhMopUgEAOPQJbVK+8DsRyQ7rtjYH6vBOFJQlh24nwVCE 3G4YWm3wrm6rjvWEEFfe8+C7kJoTdmNBw25VniDgZ8wv9Uu1GChATmKAWdPsq/yDqurhDz N9ZZeU1uJ+4IXcMWWstUYHaTrMm8bm4gBihDXBOMxg0wt4dVYQPzHzCPpo9M1sQ35WVcP6 Q2xRi6l+OZaKwzn8GPDPhVrK+tW0k6U+55yC10GW0ESfvod02xJyhWGOMoD5gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767710427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=49mrQomRWg0kyRZ/J824/keZ64INa/9HtOPW/AAH9co=; b=rLInQD7NmTYlbmEAQmZLDBth7eX4fC0g/48gMz8k7eYPlCx7o+FkkCiPEWX7PRtEXW7THu EnDkxx2r5ctxKzTcTUqS7EtHXdr8XQCZMST2tlltnmeIUTeTqrgtp+8x8t/nOzf1SAPbq1 lKiIVEoDU5PIgoKsQPhM0uZAr+8HC9FXy4NeFCcjMAKiqyI3oY2qvQ5HFvRCpzNqZr9/JD cgomEDiwV66fSOn5PiCZ3kSw/CGYBiRva+fbvDc5UMbrVbjSmd0SYH0X7SQUxTLEkbaERe iTxLW3LnKpu/fT/EmenVU8rW2ffI5JyYvDMLbrpcAidWdLffBlpc2cmJ5vYatQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767710427; a=rsa-sha256; cv=none; b=SSxW8aeanEofDNWmWnx1wwCr+uN5aGL95fHGn+N3arxmypf6lrFhgV54B0wZdCTzxIg2/r 1ZDlXiQy3cNHVHozyrthS1KZsmaU70DU9z2QrKi3dWN6jmW/eNvbCh+lwDWlO7pt3QKRBQ 1V95u0mZv7s62FN3RO3yOWBdS+pc+C+FPnXagsE7v50G9Nu6yE/WBC9/JflyAGHB6SIdhC 4Ea9c9kNmTAXtJ3F41mSSwalaEkhoSgI2bBdkRRC/OLZBFh41StaZfrvw01yzln/l+hNiy cwzckWoCX7G3+4IMNaFF+EdSF2c5ezoRiuF4e97NBAyh+IXRDhakJwEpB4BUVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [172.20.6.23] (unknown [12.195.162.27]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4dlv3H3Zz7zvPf; Tue, 06 Jan 2026 14:40:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <7ab91330-8dab-44d2-b00a-385cf61d479e@FreeBSD.org> Date: Tue, 6 Jan 2026 08:40:27 -0600 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 89c017d06870 - main - Makefile.inc1: Allow safe installkernel with pkgbase Content-Language: en-US To: Lexi Winter , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <695bfbeb.32a44.fb6c48b@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <695bfbeb.32a44.fb6c48b@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/5/26 12:59, Lexi Winter wrote: > The branch main has been updated by ivy: > > URL: https://cgit.FreeBSD.org/src/commit/?id=89c017d068704c2bc3da9cb22f43da17a9ce8c24 > > commit 89c017d068704c2bc3da9cb22f43da17a9ce8c24 > Author: Lexi Winter > AuthorDate: 2026-01-05 17:39:47 +0000 > Commit: Lexi Winter > CommitDate: 2026-01-05 17:39:47 +0000 > > Makefile.inc1: Allow safe installkernel with pkgbase > > Commit 74a6bb524e5b added a check to install{world,kernel} to avoid > people accidentally running this on pkgbase systems and leaving their > system broken. This had two issues: > > (1) The warning was not sufficiently scary, leading people to think > this was safe to do as long as they set DESTDIR=/. > > (2) The installkernel check was too strict, and prevented installing > kernels that don't conflict with packaged kernels. > > Fix (1) by rewording the warning to be scarier, and while here, add > two new variables (ALLOW_PKGBASE_INSTALL{WORLD,KERNEL}) which could > be set in /etc/make.conf for people who want to break their systems > by default. > > Fix (2) by improving the installkernel check to see if the kernel(s) > we're actually installing are packaged. This means a new kernel can > be installed to /boot/kernel as long as there's no packaged kernel > installed there. This check understands INSTKERNNAME, so if there > is a packaged kernel in /boot/kernel, the new kernel can still be > installed using INSTKERNNAME=testkernel (or whatever). > > MFC after: 2 weeks > Reported by: christos, jhb, others > Reviewed by: emaste, christos (previous version) > Sponsored by: https://www.patreon.com/bsdivy > Differential Revision: https://reviews.freebsd.org/D54346 Thanks! -- John Baldwin