From owner-dev-commits-src-main@freebsd.org Sun Aug 29 17:40:22 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1640B662E05; Sun, 29 Aug 2021 17:40:22 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GyLM96mwbz4W13; Sun, 29 Aug 2021 17:40:21 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id ADD3626395; Sun, 29 Aug 2021 17:40:21 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (unknown [IPv6:2001:470:7a58:0:5cbd:d688:6797:952]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 6186F5E3A8; Sun, 29 Aug 2021 19:40:19 +0200 (CEST) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_7CE347AC-857C-4CBF-97A9-D02D66DCD0A5"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: 5b8f07b12f84 - main - Fix -Wformat errors in pfctl on 32-bit architectures Date: Sun, 29 Aug 2021 19:40:09 +0200 In-Reply-To: <6A084192-562D-404D-9833-51A708FA1BC0@FreeBSD.org> Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" To: Kristof Provost References: <202108291531.17TFVoah033310@gitrepo.freebsd.org> <6A084192-562D-404D-9833-51A708FA1BC0@FreeBSD.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Aug 2021 17:40:22 -0000 --Apple-Mail=_7CE347AC-857C-4CBF-97A9-D02D66DCD0A5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 29 Aug 2021, at 18:00, Kristof Provost wrote: >=20 > On 29 Aug 2021, at 17:31, Dimitry Andric wrote: >> The branch main has been updated by dim: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D5b8f07b12f8477f1679013d6b3abdab8= d33c7243 >>=20 >> commit 5b8f07b12f8477f1679013d6b3abdab8d33c7243 >> Author: Dimitry Andric >> AuthorDate: 2021-08-29 15:31:28 +0000 >> Commit: Dimitry Andric >> CommitDate: 2021-08-29 15:31:28 +0000 >>=20 >> Fix -Wformat errors in pfctl on 32-bit architectures >>=20 >> Use PRIu64 to printf(3) uint64_t quantities, otherwise this will = result >> in "error: format specifies type 'unsigned long' but the argument = has >> type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]" on = 32-bit >> architectures. >>=20 >> Fixes: 80078d9d38fd >> MFC after: 1 week >=20 > Thanks! >=20 > I was running test builds for a fix, but it is so much more convenient = when other people fix my mistakes for me. I was trying buildworld on i386 for something totally unrelated, and ran into these -Wformat errors so I took the liberty of patching them up quickly. :) -Dimitry --Apple-Mail=_7CE347AC-857C-4CBF-97A9-D02D66DCD0A5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCYSvGeQAKCRCwXqMKLiCW oypoAKDix9DoDSRfCE4vcpAZjSAQkIbL8wCeLJKDpgyR8w/axdbSsvA9xG/VTjU= =eLwf -----END PGP SIGNATURE----- --Apple-Mail=_7CE347AC-857C-4CBF-97A9-D02D66DCD0A5--