From owner-freebsd-ports@FreeBSD.ORG  Tue Dec 19 00:13:21 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@freebsd.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BB3EC16A407
	for <ports@freebsd.org>; Tue, 19 Dec 2006 00:13:21 +0000 (UTC)
	(envelope-from shaun@FreeBSD.org)
Received: from dione.picobyte.net (host-212-158-207-124.bulldogdsl.com
	[212.158.207.124])
	by mx1.FreeBSD.org (Postfix) with SMTP id 0B84843C9F
	for <ports@freebsd.org>; Tue, 19 Dec 2006 00:13:18 +0000 (GMT)
	(envelope-from shaun@FreeBSD.org)
Received: from charon.picobyte.net (charon.picobyte.net
	[IPv6:2001:4bd0:201e::fe03])
	by dione.picobyte.net (Postfix) with ESMTP;
	Mon, 18 Dec 2006 23:43:40 +0000 (GMT)
Date: Mon, 18 Dec 2006 23:43:40 +0000
From: Shaun Amott <shaun@FreeBSD.org>
To: Ed Schouten <ed@fxq.nl>
Message-ID: <20061218234339.GA31019@charon.picobyte.net>
References: <20061218212213.GU1072@hoeg.nl>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft"
Content-Disposition: inline
In-Reply-To: <20061218212213.GU1072@hoeg.nl>
User-Agent: Mutt/1.5.11 (FreeBSD i386)
Cc: ports@freebsd.org
Subject: Re: How to properly check for GCC 4.1 in port
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Dec 2006 00:13:21 -0000


--/04w6evG8XlLl3ft
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 18, 2006 at 10:22:13PM +0100, Ed Schouten wrote:
>=20
> I'm the maintainer for the net/totd port. This port doesn't compile with
> GCC 4.1. The easiest fix is to add -Wno-pointer-sign to the CFLAGS. GCC
> 3.4 doesn't allow this option. What's the nicest way to add a
> conditional to the port Makefile to check for a GCC version?
>=20

Wait until OSVERSION is bumped (i.e. after gcc 4.x is imported) and use
that. There is no variable that tells you the gcc version, as far as I
know.

Alternatively, find a better fix. :-)

--=20
Shaun Amott // PGP: 0x6B387A9A
"A foolish consistency is the hobgoblin
of little minds." - Ralph Waldo Emerson

--/04w6evG8XlLl3ft
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFFhyerkmhdCGs4epoRApRtAJ9/0h633a0fEekz0fjh1HP+xMMSBQCgp73N
e/L6leelkNGWyQExdImu+Qw=
=dAee
-----END PGP SIGNATURE-----

--/04w6evG8XlLl3ft--