Date: Tue, 27 Jan 2004 16:01:53 +0100 (CET) From: Lukas Ertl <l.ertl@univie.ac.at> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: freebsd-geom@freebsd.org Subject: Re: Error checking for g_mod_event() and friends Message-ID: <20040127160001.N92925@pcle2.cc.univie.ac.at> In-Reply-To: <4821.1075215415@critter.freebsd.dk> References: <4821.1075215415@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Jan 2004, Poul-Henning Kamp wrote: > In message <20040127154303.E92925@pcle2.cc.univie.ac.at>, Lukas Ertl writes: > >Hi, > > > >is there a specific reason that the .init function of a class is declared > >to return "void"? I'd like to change that to an int, so we could do error > >checking, and subsequently modify g_load_class() to check for errors and > >so on. > > In what circumstances would class->init() fail ? In the geom_vinum case I allocate the "main" vinum geom in the init method, and this might fail. (Of course, this might not be the correct way to do it, but I couldn't think of another way.) > >Additionally, I've seen several calls to g_malloc() where the return > >values aren't checked - should I prepare some patches for these? > > yes please. Ok. regards, le -- Lukas Ertl eMail: l.ertl@univie.ac.at UNIX Systemadministrator Tel.: (+43 1) 4277-14073 Vienna University Computer Center Fax.: (+43 1) 4277-9140 University of Vienna http://mailbox.univie.ac.at/~le/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040127160001.N92925>