From owner-freebsd-geom@FreeBSD.ORG  Tue Jan 27 07:02:12 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 70E1416A4CE
	for <freebsd-geom@freebsd.org>; Tue, 27 Jan 2004 07:02:12 -0800 (PST)
Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 78A7443D39
	for <freebsd-geom@freebsd.org>; Tue, 27 Jan 2004 07:02:05 -0800 (PST)
	(envelope-from l.ertl@univie.ac.at)
Received: from pcle2.cc.univie.ac.at (pcle2.cc.univie.ac.at [131.130.2.177])
	i0RF1rsD281578;	Tue, 27 Jan 2004 16:01:57 +0100
Date: Tue, 27 Jan 2004 16:01:53 +0100 (CET)
From: Lukas Ertl <l.ertl@univie.ac.at>
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
In-Reply-To: <4821.1075215415@critter.freebsd.dk>
Message-ID: <20040127160001.N92925@pcle2.cc.univie.ac.at>
References: <4821.1075215415@critter.freebsd.dk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-DCC-ZID-Univie-Metrics: mailbox 4244; Body=0 Fuz1=0 Fuz2=0
cc: freebsd-geom@freebsd.org
Subject: Re: Error checking for g_mod_event() and friends 
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jan 2004 15:02:12 -0000

On Tue, 27 Jan 2004, Poul-Henning Kamp wrote:

> In message <20040127154303.E92925@pcle2.cc.univie.ac.at>, Lukas Ertl writes:
> >Hi,
> >
> >is there a specific reason that the .init function of a class is declared
> >to return "void"?  I'd like to change that to an int, so we could do error
> >checking, and subsequently modify g_load_class() to check for errors and
> >so on.
>
> In what circumstances would class->init() fail ?

In the geom_vinum case I allocate the "main" vinum geom in the init
method, and this might fail.

(Of course, this might not be the correct way to do it, but I couldn't
think of another way.)

> >Additionally, I've seen several calls to g_malloc() where the return
> >values aren't checked - should I prepare some patches for these?
>
> yes please.

Ok.

regards,
le

-- 
Lukas Ertl                             eMail: l.ertl@univie.ac.at
UNIX Systemadministrator               Tel.:  (+43 1) 4277-14073
Vienna University Computer Center      Fax.:  (+43 1) 4277-9140
University of Vienna                   http://mailbox.univie.ac.at/~le/