From owner-freebsd-current@FreeBSD.ORG Fri Jul 15 21:48:51 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B69E716A41C; Fri, 15 Jul 2005 21:48:51 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 645E443D48; Fri, 15 Jul 2005 21:48:51 +0000 (GMT) (envelope-from nate@root.org) Received: from [192.168.52.136] (ip-207-145-88-3.nyc.megapath.net [207.145.88.3]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j6FLmno5026289 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 15 Jul 2005 14:48:50 -0700 Message-ID: <42D82D59.9060605@root.org> Date: Fri, 15 Jul 2005 14:40:41 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Harry Coin References: <200507121027.14113.jhb@FreeBSD.org> <4.3.2.7.2.20050711121036.02caa348@mail.qconline.com> <200507111626.25124.jhb@FreeBSD.org> <42D2F177.3070101@root.org> <200507121027.14113.jhb@FreeBSD.org> <4.3.2.7.2.20050715164008.01f0fdd8@mail.qconline.com> In-Reply-To: <4.3.2.7.2.20050715164008.01f0fdd8@mail.qconline.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org, John Baldwin Subject: Re: mss.c pcm fix to ' attach returned 6 ' load failure for v5.x acpi and up X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2005 21:48:51 -0000 Harry Coin wrote: > At 02:28 PM 7/15/2005 -0700, Nate Lawson wrote: > >> Drivers should not rely on isa_get_logicalid() to determine a boolean >> "is PNP?" > > > The architecture manual specifies ISA_PNP_PROBE in non pnp ISA drivers > for that purpose. As I understand it, John doesn't like the ugly nature > of passing in a null device list for non-pnp ISA drivers. Hard to > argue with that. > > So why not gin up a tiny little boolean kernel function > 'device_is_pnp(dev)) ' that does the right thing for non-pnp isa drivers > - once -,right after wherever ISA_PNP_PROBE is defined in the kernel? I don't understand how this is needed. ACPI devices are always a superset of PNP. If a probe method is not PNP capable, it should never attach to the ACPI bus. I think that's what his fix changes, and I think it's sufficient. -- Nate