From owner-svn-src-all@freebsd.org Wed Jan 30 18:44:46 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 223AA14C973A; Wed, 30 Jan 2019 18:44:46 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 05861801A4; Wed, 30 Jan 2019 18:44:45 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-lf1-x12d.google.com with SMTP id c16so409472lfj.8; Wed, 30 Jan 2019 10:44:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kzd/f5PBm2up9bM2GwonX5WQkX5SUxI8CNWA7jJ/1ok=; b=nXOygSB1tyZ54nXBmHADYOVD7HqhO35+Hz/CAh2kpyQYti8yNclVxIM9vD7FPlZJwn Q5lu3kaeiJ3O1j/t3Ssvq7JzKhhLzKtw4KnNW51KSxOKdmP8pLjSIc39JavhyJVuJoHs NvzgcvGf94/gohA7l47w/W6N0g6GgO1DdVqOXATJZoSWxHk/raGca2gpmMMzm+cCMy8A oWItBECeycSMHhfPOII/YebMjiAL0fHFSjlL6YPM/i3TNaxUWBheRtr3G+DfIpAhLNIB Rn3ZIOf9EtQ/f83AfnF27487CB0JpXarxdZZurIVqOqAuxcxhXYBzshLrlXSky5EvoXp AcNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kzd/f5PBm2up9bM2GwonX5WQkX5SUxI8CNWA7jJ/1ok=; b=fDUwrh81AyfE1ufVj37O0cAG5HheqCCD+BN0El9gRG+7qFXyiFpM2Chx2AclZESkag cT/oxcz+dHX5fO+4CDzHA1jww2whN4+HT7WSTAqTi3nJj4PV4QQPBkdgE2c0Patp3GX8 0XeEtTEUrvXhxxNr/ng0gkDccdlRw0ySIFnlT8ASk+162tB1z5KnsvsCEiYKU9BxbIrc 83bs5k/ifIZJdeGFWuMr7N3wtVvVm3gZkfaIKPOstmr8wIrFKz0CiZO6AFYiVLFOgQD3 37ONHNIcVyZKe24ZHFtYG373yNZbJ/GWcyyQxWAzhfS7IVkbmzUlaEY71UsJo9rBOIfs PA5A== X-Gm-Message-State: AJcUukemK1EaQDwl1uc7JSuTHxGjj8oPbdkcbGrOgL842XIE6Vn9/MHj WOYUf7wyTBVEdyg+hjXJpov98hGKmbwzCCE5pQbrRw== X-Google-Smtp-Source: ALg8bN5NKiq+WxVlgrxLe+S05fPUDePOyZimmQ14r7KifTal7l/N95ExdLIWzBDMvPPoSGsA29rwO9iDXg92n0Kkj5Q= X-Received: by 2002:a19:c650:: with SMTP id w77mr25898410lff.56.1548873883105; Wed, 30 Jan 2019 10:44:43 -0800 (PST) MIME-Version: 1.0 References: <201901281245.x0SCjVpw048723@repo.freebsd.org> In-Reply-To: <201901281245.x0SCjVpw048723@repo.freebsd.org> From: Ryan Stone Date: Wed, 30 Jan 2019 13:44:32 -0500 Message-ID: Subject: Re: svn commit: r343525 - in head/sys/netinet: . tcp_stacks To: Michael Tuexen Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 05861801A4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=nXOygSB1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2a00:1450:4864:20::12d as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [-6.55 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[d.2.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; IP_SCORE(-2.66)[ip: (-8.98), ipnet: 2a00:1450::/32(-2.28), asn: 15169(-1.96), country: US(-0.07)]; NEURAL_HAM_SHORT(-0.88)[-0.882,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 18:44:46 -0000 On Mon, Jan 28, 2019 at 7:46 AM Michael Tuexen wrote: > > Author: tuexen > Date: Mon Jan 28 12:45:31 2019 > New Revision: 343525 > URL: https://svnweb.freebsd.org/changeset/base/343525 > > Log: > Fix the detection of ECN-setup SYN-ACK packets. > > RFC 3168 defines an ECN-setup SYN-ACK packet as on with the ECE flags > set and the CWR flags not set. The code was only checking if ECE flag > is set. This patch adds the check to verify that the CWR flags is not > set. Is this compatible with DCTCP? I seem to recall that it is possible for pure ACKs to be ECN marked in DCTCP.