Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Dec 2012 13:39:11 -0800
From:      Devin Teske <devin.teske@fisglobal.com>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        Devin Teske <dteske@freebsd.org>, Garrett Cooper <gcooper@FreeBSD.org>
Subject:   PR conf/121064 -- [patch] sys/boot/forth -- Use ASCII characters for box/line characters in frames.4th
Message-ID:  <CF7A6259-B174-4830-9AEA-6469891C8263@fisglobal.com>
Resent-Message-ID: <201212080043.qB80hdST015233@ltcfislmsgpa03.fnfis.com>

next in thread | raw e-mail | index | archive | help
Hi -arch,

Eitan brought PR conf/121064 to my attention.

This particular PR appears to be ~5 years old and addresses an ~10 year old=
 issue introduced by SVN r115410

Below is the commit message and patch that I'm proposing to commit for this=
 PR (also, I amended said patch to the PR audit trail; see conf/121064).

I asked gcooper to review the working/tested patch.

Here's a before/after shot (courtesy of jh) -- against 9.0-R:

http://twitpic.com/bjxfcz

Please let me know if you have any objections, feature-requests, nagging fe=
elings, etc.
--=20
Cheers,
Devin

=3D=3D=3D

Use ASCII characters for box/line characters in frames.4th

Committed with changes to support the following from loader.conf(5):
+ console=3D"vidconsole comconsole" (not just console=3D"comconsole")
+ boot_serial=3D"anything" (not just boot_serial=3D"YES")
+ boot_multicons=3D"anything" (unsupported in originally-submitted patch)

PR:             conf/121064
Submitted by:   koitsu
Reviewed by:    gcooper, adrian (co-mentor) [pending your review]
Approved by:    adrian (co-mentor) [pending your approval]
Obtained from:
MFC after:
Security:
--This line, and those below, will be ignored--
> Description of fields to fill in above:                     76 columns --|
> PR:            If a GNATS PR is affected by the change.
> Submitted by:  If someone else sent in the change.
> Reviewed by:   If someone else reviewed your modification.
> Approved by:   If you needed approval for this commit.
> Obtained from: If the change is from a third party.
> MFC after:     N [day[s]|week[s]|month[s]].  Request a reminder email.
> Security:      Vulnerability reference (one per line) or description.
> Empty fields above will be automatically removed.

M    forth/support.4th
M    forth/frames.4th

_____________
The information contained in this message is proprietary and/or confidentia=
l. If you are not the intended recipient, please: (i) delete the message an=
d all copies; (ii) do not disclose, distribute or use the message in any ma=
nner; and (iii) notify the sender immediately. In addition, please be aware=
 that any message addressed to our domain is subject to archiving and revie=
w by persons other than the intended recipient. Thank you.

_____________
The information contained in this message is proprietary and/or confidentia=
l. If you are not the intended recipient, please: (i) delete the message an=
d all copies; (ii) do not disclose, distribute or use the message in any ma=
nner; and (iii) notify the sender immediately. In addition, please be aware=
 that any message addressed to our domain is subject to archiving and revie=
w by persons other than the intended recipient. Thank you.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CF7A6259-B174-4830-9AEA-6469891C8263>