From owner-p4-projects@FreeBSD.ORG  Thu Aug 13 09:37:10 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id ADDBD1065674; Thu, 13 Aug 2009 09:37:10 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6D919106566C;
	Thu, 13 Aug 2009 09:37:10 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe01.swip.net [212.247.154.1])
	by mx1.freebsd.org (Postfix) with ESMTP id D0CBD8FC3F;
	Thu, 13 Aug 2009 09:37:09 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=lhnSkr7iC74A:10
	a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=7KFJx-MvmLwmaQojHcsA:9
	a=4UFAlyqvYdmDNp1_4H1UP79-LlkA:4
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop.adsl.tele2.no)
	by mailfe01.swip.net (CommuniGate Pro SMTP 5.2.13)
	with ESMTPA id 239288280; Thu, 13 Aug 2009 11:37:07 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: Sylvestre Gallon <syl@freebsd.org>
Date: Thu, 13 Aug 2009 11:37:12 +0200
User-Agent: KMail/1.11.4 (FreeBSD/8.0-BETA2; KDE/4.2.4; i386; ; )
References: <200908121834.n7CIY6J1033878@repoman.freebsd.org>
In-Reply-To: <200908121834.n7CIY6J1033878@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200908131137.13574.hselasky@c2i.net>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 167253 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Aug 2009 09:37:11 -0000

On Wednesday 12 August 2009 20:34:06 Sylvestre Gallon wrote:
> +       bzero(&fops, sizeof(struct usb_roothub_fops));
> +       fops.handle_get_port_status = &at91dci_get_port_status;
> +       fops.handle_clocks_on = (usb_clocks_fops_t)&at91dci_clocks_on;
> +       fops.handle_clocks_off = (usb_clocks_fops_t)&at91dci_clocks_off;
> +       fops.handle_pull_up = (usb_clocks_fops_t)&at91dci_pull_up;
> +       fops.handle_pull_down = (usb_clocks_fops_t)&at91dci_pull_down;
> +       fops.handle_wakeup_peer = (usb_clocks_fops_t)&at91dci_wakeup_peer;

Can you make the fops static const?

--HPS