From owner-freebsd-bugs@FreeBSD.ORG Thu Oct 29 06:50:02 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B9F6106566C for ; Thu, 29 Oct 2009 06:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F3EFF8FC18 for ; Thu, 29 Oct 2009 06:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9T6o12o037299 for ; Thu, 29 Oct 2009 06:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9T6o1Zi037298; Thu, 29 Oct 2009 06:50:01 GMT (envelope-from gnats) Resent-Date: Thu, 29 Oct 2009 06:50:01 GMT Resent-Message-Id: <200910290650.n9T6o1Zi037298@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tom Uffner Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D47A11065692 for ; Thu, 29 Oct 2009 06:49:04 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id C3F078FC0A for ; Thu, 29 Oct 2009 06:49:04 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n9T6n3bU068312 for ; Thu, 29 Oct 2009 06:49:03 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n9T6n3Wr068311; Thu, 29 Oct 2009 06:49:03 GMT (envelope-from nobody) Message-Id: <200910290649.n9T6n3Wr068311@www.freebsd.org> Date: Thu, 29 Oct 2009 06:49:03 GMT From: Tom Uffner To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/140068: [patch] smbfs does not allow semicolon in filenames, but should X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2009 06:50:02 -0000 >Number: 140068 >Category: kern >Synopsis: [patch] smbfs does not allow semicolon in filenames, but should >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Oct 29 06:50:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Tom Uffner >Release: 7.x, 8.0, 9-current >Organization: >Environment: FreeBSD xiombarg.uffner.com 9.0-CURRENT FreeBSD 9.0-CURRENT #52: Tue Oct 27 03:32:12 EDT 2009 root@xiombarg.uffner.com:/usr/obj/usr/src/sys/XIOMBARG i386 >Description: Semicolon (';') is a legal character in modern MS Windows filesystems (FAT32 & NTFS). it is allowed by Windows, Linux & Samba. But on FreeBSD using mount_smbfs, it is not possible to create a file or directory with a semicolon in the name. >How-To-Repeat: mount a windows or samba share. `% touch a\;1' or `% mkdir b\;1' >Fix: delete ';' from badchars in sys/fs/smbfs/smbfs_vnops.c Patch attached with submission follows: --- sys/fs/smbfs/smbfs_vnops.c.orig 2009-10-29 00:00:31.000000000 -0400 +++ sys/fs/smbfs/smbfs_vnops.c 2009-10-29 00:02:18.000000000 -0400 @@ -1036,7 +1036,7 @@ static int smbfs_pathcheck(struct smbmount *smp, const char *name, int nmlen, int nameiop) { - static const char *badchars = "*/:<>;?"; + static const char *badchars = "*/:<>?"; static const char *badchars83 = " +|,[]="; const char *cp; int i, error; >Release-Note: >Audit-Trail: >Unformatted: