From owner-freebsd-bugs@FreeBSD.ORG  Fri May  8 02:00:11 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 10FFA106567E
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  8 May 2009 02:00:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 068DF8FC2D
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  8 May 2009 02:00:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n482088B040300
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 8 May 2009 02:00:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n482087A040299;
	Fri, 8 May 2009 02:00:08 GMT (envelope-from gnats)
Resent-Date: Fri, 8 May 2009 02:00:08 GMT
Resent-Message-Id: <200905080200.n482087A040299@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Martin Karsten <mkarsten@cs.uwaterloo.ca>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8B33E106566B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri,  8 May 2009 01:54:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 79B618FC18
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri,  8 May 2009 01:54:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n481sUxY048567
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 8 May 2009 01:54:30 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n481sUWh048544;
	Fri, 8 May 2009 01:54:30 GMT (envelope-from nobody)
Message-Id: <200905080154.n481sUWh048544@www.freebsd.org>
Date: Fri, 8 May 2009 01:54:30 GMT
From: Martin Karsten <mkarsten@cs.uwaterloo.ca>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/134355: cooments for m_getm2 inconsistent with behaviour
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 May 2009 02:00:12 -0000


>Number:         134355
>Category:       kern
>Synopsis:       cooments for m_getm2 inconsistent with behaviour
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 08 02:00:08 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Martin Karsten
>Release:        7.2
>Organization:
University of Waterloo
>Environment:
FreeBSD i01.expnet 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Fri May  1 08:49:13 UTC 2009     root@walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
It seems to me that the comments describing m_getm2 are inconsistent with the behaviour. The comment states that the function returns the top of the newly allocated chain, but it in fact returns the top of the overall chain.

>How-To-Repeat:
N/A

>Fix:
To return the top of the newly allocated chain, the last statement in line 151 would need to be changed from

  return (m);

to

  return (nm);

and the very last else-clause before that is not needed.


>Release-Note:
>Audit-Trail:
>Unformatted: