From owner-freebsd-rc@FreeBSD.ORG Sat Nov 3 12:21:59 2012 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9FFDF2C8; Sat, 3 Nov 2012 12:21:59 +0000 (UTC) (envelope-from crees@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 879998FC08; Sat, 3 Nov 2012 12:21:59 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qA3CLxiX062894; Sat, 3 Nov 2012 12:21:59 GMT (envelope-from crees@freefall.freebsd.org) Received: (from crees@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qA3CLwHO062890; Sat, 3 Nov 2012 12:21:58 GMT (envelope-from crees) Date: Sat, 3 Nov 2012 12:21:58 GMT Message-Id: <201211031221.qA3CLwHO062890@freefall.freebsd.org> To: david@nfrance.com, crees@FreeBSD.org, freebsd-rc@FreeBSD.org From: crees@FreeBSD.org Subject: Re: conf/142973: [jail] [patch] Strange counter init value in jail rc X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Nov 2012 12:21:59 -0000 Synopsis: [jail] [patch] Strange counter init value in jail rc State-Changed-From-To: open->analyzed State-Changed-By: crees State-Changed-When: Sat Nov 3 12:21:57 UTC 2012 State-Changed-Why: This is a pickle indeed. Moany people will have used it starting from 1, since the original code was intended to count from 1; see r159072. However, the prestart code added in r191620 counts from 0. The patch at http://www.bayofrum.net/~crees/patches/142973.diff makes it count from 0, but still work with a warning if the user has started at 1. I will talk to the developers concerned. http://www.freebsd.org/cgi/query-pr.cgi?pr=142973