From owner-freebsd-current@FreeBSD.ORG  Thu Sep 29 04:42:57 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 75346106566C
	for <freebsd-current@freebsd.org>; Thu, 29 Sep 2011 04:42:57 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-yi0-f54.google.com (mail-yi0-f54.google.com
	[209.85.218.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 361BD8FC16
	for <freebsd-current@freebsd.org>; Thu, 29 Sep 2011 04:42:56 +0000 (UTC)
Received: by yia13 with SMTP id 13so238259yia.13
	for <freebsd-current@freebsd.org>; Wed, 28 Sep 2011 21:42:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=UaeGme+tOEZ3Yqgt7SHdu+6aQrFW0CtzM8KQmuPJwWU=;
	b=gR3sFqU7ZpkGJxq6uA2N3PGknauJZpdXhAAYH1MA3Tx62+WsoJbssguRuUHQ7Hnuic
	46BaZbQKyuWNfuk2OhnSw6zfBF7cCmZ2qdL+XaQFF/NbRNcHbSRKr6ZrvfF+YXPLVm+E
	1s/EYdpkO717i2aE4QtDaL898EWXx3Yce3uWM=
MIME-Version: 1.0
Received: by 10.236.201.165 with SMTP id b25mr10948908yho.72.1317271376435;
	Wed, 28 Sep 2011 21:42:56 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.236.111.42 with HTTP; Wed, 28 Sep 2011 21:42:56 -0700 (PDT)
In-Reply-To: <CAHLcusRRzXkMDBma8oyx-vcrvyKB33nBV5tE12bTL-p8dKhbmw@mail.gmail.com>
References: <CAHLcusRRzXkMDBma8oyx-vcrvyKB33nBV5tE12bTL-p8dKhbmw@mail.gmail.com>
Date: Thu, 29 Sep 2011 12:42:56 +0800
X-Google-Sender-Auth: wtfROT_of75mXgk4haBmc8BlIEc
Message-ID: <CAJ-Vmomy3WCQ_CinY3mnm1AUWu=Q28R1UiGzh9Z8B_1y3WXdAw@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Greg Miller <greglmiller@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-current@freebsd.org
Subject: Re: make buildworld error on 9.0B2
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2011 04:42:57 -0000

On 29 September 2011 08:57, Greg Miller <greglmiller@gmail.com> wrote:
> On a fresh install of 9.0B2, I've updated my source to RELENG_9 with
> csup, and I get the following when I try to make buildworld:

Good, is this reproducable? There's a patch to csup that may help you
out with this.

Index: src/usr.bin/csup/fixups.c
===================================================================
--- src/usr.bin/csup/fixups.c   (revision 225772)
+++ src/usr.bin/csup/fixups.c   (working copy)
@@ -141,7 +141,7 @@
        fixups_lock(f);
        while (f->size == 0 && !f->closed)
                pthread_cond_wait(&f->cond, &f->lock);
-       if (f->closed) {
+       if (f->size == 0) {
                fixups_unlock(f);
                return (NULL);
        }

I know this is a bit of effort, but can you please reproduce the
issue, then see if this patch fixes it for you?
I'd like to try and get this into 9.0-RELEASE but there's no csup
maintainer so I'm just relying on "works for me" and code reviews from
others.

Thanks,

Adrian