From owner-freebsd-ports@freebsd.org Tue Apr 5 21:37:28 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BFA0DB04FF9 for ; Tue, 5 Apr 2016 21:37:28 +0000 (UTC) (envelope-from martin@waschbuesch.de) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id AA0361FBA for ; Tue, 5 Apr 2016 21:37:28 +0000 (UTC) (envelope-from martin@waschbuesch.de) Received: by mailman.ysv.freebsd.org (Postfix) id A597CB04FF8; Tue, 5 Apr 2016 21:37:28 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A53A8B04FF7 for ; Tue, 5 Apr 2016 21:37:28 +0000 (UTC) (envelope-from martin@waschbuesch.de) Received: from relay.waschbuesch.it (relay.waschbuesch.it [IPv6:2a00:cba0:0:100::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.waschbuesch.it", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 69BB21FB9 for ; Tue, 5 Apr 2016 21:37:28 +0000 (UTC) (envelope-from martin@waschbuesch.de) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=waschbuesch.de; s=dkim; h=To:References:Message-Id: Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version: Content-Type; bh=/Msb9JCIMkJLAGuIqeWM6zM2v5LzMQBuaCjwuijk2ts=; b=VOTO2cMQBTU1 QleptY/lRLkZprTJDzqOMOI1bIGLfQkSuoGb3pz/gvZovxy94Ezaxa5iFceW2koUwwPr34FrYHq3+ OQB/ssGUE0NpvCqp1ZxxyiOccBNsJqrOdktl9cIEMb6ynK7Tol6B8EvQh0Qphhc13VaCfUDRAVCkF hprtI=; Received: by relay.waschbuesch.it with esmtpsa (TLSv1:ECDHE-RSA-AES256-SHA:256) (Exim) (envelope-from ) id 1anYey-000NIv-6P; Tue, 05 Apr 2016 21:37:17 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: Committer needed for PR 208029 From: =?utf-8?Q?Martin_Waschb=C3=BCsch?= In-Reply-To: <57042958.5010701@sorbs.net> Date: Tue, 5 Apr 2016 23:37:16 +0200 Cc: Kurt Jaeger , ports@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <498CA3F8-15EF-45BD-880C-241F83CBE3DD@waschbuesch.de> <20160405185159.GK35640@home.opsec.eu> <20160405200835.GM35640@home.opsec.eu> <57042958.5010701@sorbs.net> To: Michelle Sullivan X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2016 21:37:28 -0000 > Umm probably a really bad idea... consider this or something more = creative/descriptive: >=20 > .if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} < 1000000 && = ${WITH_OPENSSL_PORT} !=3D "yes" > BROKEN=3D You must set WITH_OPENSSL_PORT=3Dyes in = /etc/make.conf on Pre 10.x > .endif >=20 >=20 > ... the idea instead of silently turning it on which could cause a = myriad of hell for production systems where some ports are compiled = against security/openssl and some against the base openssl... stop the = compile and tell the user what they have to do to resolve it... which = will then make anything else use the same openssl and lessen the = dependency/library issues that could happen. Actually, I just noticed (when compiling the port), that the Makefile = now says: WITH_OPENSSL_PORT=3Dyes GNUTLS_CONFIGURE_WITH=3D gnutls GNUTLS_LIB_DEPENDS=3D libgnutls.so:security/gnutls POLARSSL_CONFIGURE_WITH=3Dmbedtls POLARSSL_LIB_DEPENDS=3D libmbedtls.so:security/polarssl13 .include .if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} < 1000000 WITH_OPENSSL_PORT=3Dyes .endif Which means that the ports version is used regardless of OSVERSION... Shall I open a PR for it and incorporate the BROKEN=3D approach? Martin=