From owner-freebsd-bugs@FreeBSD.ORG Tue Jul 30 13:20:00 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9E26D78A for ; Tue, 30 Jul 2013 13:20:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7D4222278 for ; Tue, 30 Jul 2013 13:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r6UDK0vu090111 for ; Tue, 30 Jul 2013 13:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r6UDK0WR090110; Tue, 30 Jul 2013 13:20:00 GMT (envelope-from gnats) Resent-Date: Tue, 30 Jul 2013 13:20:00 GMT Resent-Message-Id: <201307301320.r6UDK0WR090110@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andrew Yong Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9D5D459F for ; Tue, 30 Jul 2013 13:10:35 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8A42221FD for ; Tue, 30 Jul 2013 13:10:35 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r6UDAZAC015176 for ; Tue, 30 Jul 2013 13:10:35 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r6UDAZ8R015171; Tue, 30 Jul 2013 13:10:35 GMT (envelope-from nobody) Message-Id: <201307301310.r6UDAZ8R015171@oldred.freebsd.org> Date: Tue, 30 Jul 2013 13:10:35 GMT From: Andrew Yong To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: misc/180948: Fix for BCM57780 LEDs in if_bge.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jul 2013 13:20:00 -0000 >Number: 180948 >Category: misc >Synopsis: Fix for BCM57780 LEDs in if_bge.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 30 13:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Andrew Yong >Release: 8.3-RELEASE >Organization: - >Environment: FreeBSD edge.0x.sg 8.3-RELEASE-p8 FreeBSD 8.3-RELEASE-p8 #1: Mon Jul 29 16:54:59 EDT 2013 root@snapshots-8_3-amd64.builders.pfsense.org:/usr/obj.pfSense/usr/pfSensesrc/src/sys/pfSense_SMP.8 amd64 >Description: Activity and Link LEDs do not work on BCM57780 NICs. >How-To-Repeat: Load bge modules. LEDs remain non-functional after warm reboot. >Fix: Fixed in HEAD: http://svnweb.freebsd.org/base/head/sys/dev/bge/if_bge.c?r1=251733&r2=252227 Patch against 8.3-RELENG: --- if_bge.c 2013-07-30 21:01:07.000000000 +0800 +++ if_bge.c 2013-07-30 21:01:27.000000000 +0800 @@ -2030,7 +2030,7 @@ CSR_WRITE_4(sc, BGE_MAC_MODE, val); /* Set misc. local control, enable interrupts on attentions */ - CSR_WRITE_4(sc, BGE_MISC_LOCAL_CTL, BGE_MLC_INTR_ONATTN); + BGE_SETBIT(sc, BGE_MISC_LOCAL_CTL, BGE_MLC_INTR_ONATTN); #ifdef notdef /* Assert GPIO pins for PHY reset */ Patch attached with submission follows: --- if_bge.c.head 2013-07-30 21:01:07.000000000 +0800 +++ if_bge.c 2013-07-30 21:01:27.000000000 +0800 @@ -2030,7 +2030,7 @@ CSR_WRITE_4(sc, BGE_MAC_MODE, val); /* Set misc. local control, enable interrupts on attentions */ - CSR_WRITE_4(sc, BGE_MISC_LOCAL_CTL, BGE_MLC_INTR_ONATTN); + BGE_SETBIT(sc, BGE_MISC_LOCAL_CTL, BGE_MLC_INTR_ONATTN); #ifdef notdef /* Assert GPIO pins for PHY reset */ >Release-Note: >Audit-Trail: >Unformatted: