From owner-freebsd-net@freebsd.org Tue Jan 12 03:09:21 2016 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4396BA6CE0E for ; Tue, 12 Jan 2016 03:09:21 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1ED08152F for ; Tue, 12 Jan 2016 03:09:20 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x230.google.com with SMTP id q21so370163443iod.0 for ; Mon, 11 Jan 2016 19:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=8y7f8iquqMYfCNq/7bumRmOoE7fo03oITJn2+AyHpuk=; b=xASFAO6+dv995Cj9rq5gzUgO6nQS7071eV1vtFvZ+VPzmt8bAI1gfqmKxSqFiUlg1u 1rmgmrWX4wXvVs4DVLkD/5RXoCWhlsGg8xrexBaTsHi2ShIc0GCSX72eBwurC0T6vMpw 05l4X0NmF8MS1yYw1+mBMYkdvdTHGoGD5tl41yxlqbmc3CGKXwkZ7CvZEYK2xbTKL3q5 9hxdiwbZTODRCpE+nrZBef9YhCM40BuA69rdt1L0QrXfxTINM/v4X7RQY/aCKQAkBYv9 m7Qfkyy6/EgL4d/9X0uLAFukwHpqsOJx0VKPXLp4HS8+DWuU20afezureLIeZ3ertMwI 0SmQ== MIME-Version: 1.0 X-Received: by 10.107.11.162 with SMTP id 34mr111891733iol.165.1452568160021; Mon, 11 Jan 2016 19:09:20 -0800 (PST) Received: by 10.36.121.202 with HTTP; Mon, 11 Jan 2016 19:09:19 -0800 (PST) In-Reply-To: <0fee05072a9741609f47ca53e0797759@SG2PR3002MB0106.064d.mgd.msft.net> References: <20160111154307.GK6605@strugglingcoder.info> <0fee05072a9741609f47ca53e0797759@SG2PR3002MB0106.064d.mgd.msft.net> Date: Mon, 11 Jan 2016 19:09:19 -0800 Message-ID: Subject: Re: Is there any plan to support GRO From: Adrian Chadd To: Hongjiang Zhang Cc: hiren panchasara , "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2016 03:09:21 -0000 Hi, On 11 January 2016 at 18:18, Hongjiang Zhang wrote: > Hi Hiren, > > Thanks for your information. I found some information from internet (https://lwn.net/Articles/358910/), which talks the difference of LRO and GRO on Linux, and it also points out some shortcomings of LRO: breaks things if system works as a router. > > So, how about LRO in FreeBSD? > Could you please share the plan for LRO improvement? It'd be relatively easy to add extra field checks to the LRO code to support the extra sanity checks the Linux GRO implementation is doing. We already do some basic sanity checks to ensure the packets are part of the same TCP stream. I don't know about things like VLANs that have been decapsulated by the NIC; that's likely worth investigating and fixing. But yes, adding more sanity checks isn't hard. Patches gratefully accepted. :) -adrian