From nobody Mon Feb 16 08:14:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fDwXf32TBz6SVCd for ; Mon, 16 Feb 2026 08:14:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fDwXd5yL1z3cKY for ; Mon, 16 Feb 2026 08:14:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771229649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SyiY1lBcRzJIDN3/8hiQ5Vm0QYEwUgSoj1151FrpbuU=; b=IUq+A58U08VuMZ6dJu/0LYlLhz3PmMIMZCoU/UxOo42EeDVPJoJ96bWUN9R9uroC47xSrd 9uAZCVCqqIMgUNAlZmUT1w8pO9qC6wYSUShRFZ4GaW+lLaRUJYIz7Pr7KPq0itdis0aMwL 4EAOmCMtdHJXaen0zelCrcmg/4m8SkcbP+yZD1JNWFe+jeWNJ6ZGwORqIeNWqTLGpI2cMU 77XxfEhPSlj15I6kbretXrcu5M/wxRNURvkaFarqplwLEijYSshSb6ZJyPXvaEEMVVaPBQ zxkcvOMBRwziQOVr709bmtJ18ZngUquM2j/1aJlYoW0brzw45oiq7b/15Og3oQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771229649; a=rsa-sha256; cv=none; b=JaALl3ZYH65STaO+VU9DbB3MUBcOqGzPKwkT7jIHvj9KvmoV9EZkBk8+tZF3UztaRY36n7 08ymxml5VVvybxX94NpUBolo1ZOChaNyNcEvIRTEnBkZIowK53mKlIhd9d61A+2aT8vsNG lmyvARmOctt39ljQ3I0jG+VArw3dLjg5xXy2NE5lezfd3GpYHp5FpjHsrASZdJ3EHFOGaf qm0NI57mH1s/d+2GJHfXj4BfWtrChMq8v2L9YPM2R0F+iJCWLlaGnoxDFY4m6L6PXpwqtk rrO0yLqa7hi06eqq79TdRI9qaFWKdHZ2QXG3uxI+//CAhCo6N8lELJLxl6grNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771229649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SyiY1lBcRzJIDN3/8hiQ5Vm0QYEwUgSoj1151FrpbuU=; b=aiFoRPaFINH2Hp366yVa4mWaNLBWy0NmLlW57XrYCIYdhNISTwKdaSPj8NeIKoBCWiCjET o8X5EeWQeCzSRNPv7Bz7tnzF+8dCors3LnCGJTRPjCcH+0iY95YiZAIJXkz0vPQ/PN/htC zWzlJiqv7rYb30JH7y9ghkcJr05xGoMSqJx/Qs1MdV8YLDqAWds+JLH4Gn0Ei1YrGDtrXR BeOkZp2ZbpKA7gGsfQcj8d1JB2G6Q+PAjYw3ahpfAsfeHoeVti1hqYswkGbBdq1r2kFeO1 ypR93Xwpi8jdo6wItSaHpqEhdv+A5mhNkDmS6eKy2A6fQHcWyxok8DuWieC3WA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fDwXd53H5z1Cv for ; Mon, 16 Feb 2026 08:14:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 46a41 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 16 Feb 2026 08:14:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Baptiste Daroussin Subject: git: 38c183326425 - main - libusb: dequeue next transfer on completion to prevent stalls List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bapt X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 38c18332642500fdfe075a82f88e033f6673a53f Auto-Submitted: auto-generated Date: Mon, 16 Feb 2026 08:14:09 +0000 Message-Id: <6992d1d1.46a41.4e799729@gitrepo.freebsd.org> The branch main has been updated by bapt: URL: https://cgit.FreeBSD.org/src/commit/?id=38c18332642500fdfe075a82f88e033f6673a53f commit 38c18332642500fdfe075a82f88e033f6673a53f Author: Baptiste Daroussin AuthorDate: 2026-02-15 18:07:07 +0000 Commit: Baptiste Daroussin CommitDate: 2026-02-16 08:14:05 +0000 libusb: dequeue next transfer on completion to prevent stalls The transfer proxy callbacks (bulk/interrupt, control, isochronous) only called libusb10_submit_transfer_sub() in the START path to pipeline the second kernel transfer slot. On completion or error, no attempt was made to dequeue the next pending transfer from tr_head onto the now-free slot. When more than two async transfers were submitted on the same endpoint, the third (and subsequent) transfers would remain stuck on tr_head indefinitely, since no completion ever triggered their submission. This caused a protocol-level deadlock in applications like adb that submit header + payload + zero-length terminator as three separate bulk transfers in sequence. Fix by calling libusb10_submit_transfer_sub() after every libusb10_complete_transfer() in all three proxy callbacks. MFC After: 2 weeks Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D55289 --- lib/libusb/libusb10.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/lib/libusb/libusb10.c b/lib/libusb/libusb10.c index e226def0b7b6..b3af017ab980 100644 --- a/lib/libusb/libusb10.c +++ b/lib/libusb/libusb10.c @@ -1259,6 +1259,9 @@ libusb10_isoc_proxy(struct libusb20_transfer *pxfer) libusb20_tr_get_length(pxfer, i); } libusb10_complete_transfer(pxfer, sxfer, LIBUSB_TRANSFER_COMPLETED); + + /* start next queued transfer, if any */ + libusb10_submit_transfer_sub(libusb20_tr_get_priv_sc0(pxfer), uxfer->endpoint); break; case LIBUSB20_TRANSFER_START: /* setup length(s) */ @@ -1281,6 +1284,9 @@ libusb10_isoc_proxy(struct libusb20_transfer *pxfer) break; default: libusb10_complete_transfer(pxfer, sxfer, libusb10_convert_error(status)); + + /* start next queued transfer, if any */ + libusb10_submit_transfer_sub(libusb20_tr_get_priv_sc0(pxfer), uxfer->endpoint); break; } } @@ -1322,11 +1328,15 @@ libusb10_bulk_intr_proxy(struct libusb20_transfer *pxfer) } else { libusb10_complete_transfer(pxfer, sxfer, LIBUSB_TRANSFER_COMPLETED); } + /* start next queued transfer, if any */ + libusb10_submit_transfer_sub(libusb20_tr_get_priv_sc0(pxfer), uxfer->endpoint); break; } /* check for end of data */ if (sxfer->rem_len == 0) { libusb10_complete_transfer(pxfer, sxfer, LIBUSB_TRANSFER_COMPLETED); + /* start next queued transfer, if any */ + libusb10_submit_transfer_sub(libusb20_tr_get_priv_sc0(pxfer), uxfer->endpoint); break; } /* FALLTHROUGH */ @@ -1353,6 +1363,8 @@ libusb10_bulk_intr_proxy(struct libusb20_transfer *pxfer) default: libusb10_complete_transfer(pxfer, sxfer, libusb10_convert_error(status)); + /* start next queued transfer, if any */ + libusb10_submit_transfer_sub(libusb20_tr_get_priv_sc0(pxfer), uxfer->endpoint); break; } } @@ -1397,11 +1409,15 @@ libusb10_ctrl_proxy(struct libusb20_transfer *pxfer) } else { libusb10_complete_transfer(pxfer, sxfer, LIBUSB_TRANSFER_COMPLETED); } + /* start next queued transfer, if any */ + libusb10_submit_transfer_sub(libusb20_tr_get_priv_sc0(pxfer), uxfer->endpoint); break; } /* check for end of data */ if (sxfer->rem_len == 0) { libusb10_complete_transfer(pxfer, sxfer, LIBUSB_TRANSFER_COMPLETED); + /* start next queued transfer, if any */ + libusb10_submit_transfer_sub(libusb20_tr_get_priv_sc0(pxfer), uxfer->endpoint); break; } /* FALLTHROUGH */ @@ -1442,6 +1458,8 @@ libusb10_ctrl_proxy(struct libusb20_transfer *pxfer) default: libusb10_complete_transfer(pxfer, sxfer, libusb10_convert_error(status)); + /* start next queued transfer, if any */ + libusb10_submit_transfer_sub(libusb20_tr_get_priv_sc0(pxfer), uxfer->endpoint); break; } }