From owner-svn-src-head@freebsd.org Thu Nov 24 20:33:14 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3D51C54F10; Thu, 24 Nov 2016 20:33:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x22a.google.com (mail-pg0-x22a.google.com [IPv6:2607:f8b0:400e:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 73A0CC12; Thu, 24 Nov 2016 20:33:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x22a.google.com with SMTP id f188so21456927pgc.3; Thu, 24 Nov 2016 12:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=BYoh1GcXSJOzYlpZXRAB+R10g5CvoiDCV+NO2giuZkk=; b=TlQzTmmlX5xJtxGAF3j0V9gKOD7kUbfJNU2vfYM+jHbgJa9FfNT7fep42X4wjpdK57 IDh6kaaaaMga33FjaISPCEHVElCMr1Ety1IZEEO5k1uDWIAUPuGkRABlm/D5I4oSONq+ U8L6lyNkaoRatkkDzMkOSnkwpSUdigkF5xTq0vbcWzy9YN8HV/HFq0QOXnn6KqJYtOUu lIsgsTIxXqKqsyCK1JE6X/U1E67CucPas8FcExgbYSxgTlTaCP5EykLxGilpufIlLGh+ 6z64z1MboIUbb7QV5iQOLKKfwhbef6Wx9/FlL4lKfkE9qrVvCNmA72DF+QvCRFRgUlw8 yy6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=BYoh1GcXSJOzYlpZXRAB+R10g5CvoiDCV+NO2giuZkk=; b=QxytqMZIyDQUOFT6cy0fIVcpek+Cxa40N+rDbaj5OnTkZuv8LrA9O92WSJxDKuWE7F mqp49Wl8NIjyp8eVZmeLr/e+0Q6UJS3g3T2SkDsxOtKNW1w5TPb/bjfXaDd+f5kRMKLD 5fFiN7Bq7uvkBnyiRkRjEhz9meqgajv+n+RerOTAxFu/oeO9qOlcd7rAwQ1MNrrlrOcX 8E9R6pyPoDO3nJBqRrYqIeSq46vb3iBYB40AVkNm0HCMZjhnXiRpMU63k70xcli1AYjn Lc5M4/FDvcfG03bh8lDw7beVcBVKubhSQ5Ash+EXY9ZZcrgVo2dJVe2NFutP3ftF4nM5 Zeqw== X-Gm-Message-State: AKaTC01G2EY3/8vg75/08ZlaofXl8X+LsSoP1eae78CcX92DOM4xMslrCj/BXNunNmQW+w== X-Received: by 10.98.59.82 with SMTP id i79mr4062637pfa.147.1480019593586; Thu, 24 Nov 2016 12:33:13 -0800 (PST) Received: from fuji-wireless.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id 72sm58975976pfw.37.2016.11.24.12.33.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Nov 2016 12:33:12 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: svn commit: r309109 - head/lib/libutil From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <2600117.GH2pUSAs7N@ralph.baldwin.cx> Date: Thu, 24 Nov 2016 12:33:11 -0800 Cc: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201611241450.uAOEoLA5079215@repo.freebsd.org> <2600117.GH2pUSAs7N@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.3251) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 20:33:14 -0000 > On Nov 24, 2016, at 11:06 AM, John Baldwin wrote: >=20 > On Thursday, November 24, 2016 02:50:21 PM Dag-Erling Sm=C3=B8rgrav = wrote: >> Author: des >> Date: Thu Nov 24 14:50:21 2016 >> New Revision: 309109 >> URL: https://svnweb.freebsd.org/changeset/base/309109 >>=20 >> Log: >> Add a warning against modifying this code without understanding it, = and >> an example of how not to make it more portable. I've had this lying >> around uncommitted since 2009... >=20 > While I think the sentiment is correct, I would suggest adjusting the = comment > as some folks may not get the sarcasm on first blush. Even though it = somewhat > duplicates the revision log, I think it would be useful to expand the = comment > to list some of the "obvious" improvements to this function that = actually > break it along with a brief explanation of the breakage each of these = changes > cause. In particular, the code here doesn't explain why close-on-exec = would > be bad, but a comment as I've described would. +1 I think this is probably the most constructive comment on this thread = and it echoes my sentiments. Thanks, -Ngie=