From owner-cvs-all@FreeBSD.ORG  Fri Sep 17 04:58:17 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ED9AB16A4CE; Fri, 17 Sep 2004 04:58:17 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E1E7643D31; Fri, 17 Sep 2004 04:58:17 +0000 (GMT)
	(envelope-from wpaul@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i8H4wHVo064626;
	Fri, 17 Sep 2004 04:58:17 GMT
	(envelope-from wpaul@repoman.freebsd.org)
Received: (from wpaul@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i8H4wHxh064625;
	Fri, 17 Sep 2004 04:58:17 GMT
	(envelope-from wpaul)
Message-Id: <200409170458.i8H4wHxh064625@repoman.freebsd.org>
From: Bill Paul <wpaul@FreeBSD.org>
Date: Fri, 17 Sep 2004 04:58:17 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/dev/bge if_bge.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Sep 2004 04:58:18 -0000

wpaul       2004-09-17 04:58:17 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/bge          if_bge.c 
  Log:
  Commit patch to supress spurious link change events. Apparently, with
  copper NICs, a link change event is posted whenever MII autopolling is
  toggled off and on, which happens whenever someone calls
  bge_miibus_readreg() or bge_miibus_writereg() to access the PHY
  registers. This means anytime someone called the SIOCGIFMEDIA ioctl
  on a bge interface, the link would reset. Even a simple "ifconfig bge0"
  would do it, though other apps like dhclient or the PPPoE daemon could
  trigger it as well. An obvious symptom of this problem is lots of
  "bgeX: gigabit link up" messages appearing on the console for no
  apparent reason.
  
  Through experimentation, I determined that when a real link change
  event occurs, the BGE_MIMODE_AUTOPOLL in the BGE_MI_MODE register
  is always set, so now if we have a copper NIC and an link change
  event occurs and the BGE_MIMODE_AUTOPOLL bit is clear, we ignore
  the event.
  
  Note that this does not apply to the original BCM5700 chip since we
  use a different method for sensing link changes with that chip (the
  status block method was broken), nor to fiber optic NICs since they
  don't use the GMII PHY access registers.
  
  Revision  Changes    Path
  1.73      +11 -2     src/sys/dev/bge/if_bge.c