From owner-svn-src-all@FreeBSD.ORG Tue Jan 17 14:33:08 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 448471065672 for ; Tue, 17 Jan 2012 14:33:08 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 9EEB28FC14 for ; Tue, 17 Jan 2012 14:33:07 +0000 (UTC) Received: (qmail 71614 invoked from network); 17 Jan 2012 12:29:29 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 17 Jan 2012 12:29:29 -0000 Message-ID: <4F15805D.3040206@freebsd.org> Date: Tue, 17 Jan 2012 15:06:21 +0100 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Gleb Smirnoff References: <201201171213.q0HCDbfj089892@svn.freebsd.org> <20120117121601.GF12760@FreeBSD.org> In-Reply-To: <20120117121601.GF12760@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r230264 - head/sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2012 14:33:08 -0000 On 17.01.2012 13:16, Gleb Smirnoff wrote: > On Tue, Jan 17, 2012 at 12:13:37PM +0000, Gleb Smirnoff wrote: > T> Author: glebius > T> Date: Tue Jan 17 12:13:36 2012 > T> New Revision: 230264 > T> URL: http://svn.freebsd.org/changeset/base/230264 > T> > T> Log: > T> Provide a function m_get2() that allocates a minimal mbuf that > T> would fit specified size. Returned mbuf may be a single mbuf, > T> an mbuf with a cluster from packet zone, or an mbuf with jumbo > T> cluster of sufficient size. > > I am open to discussion on bikeshed color^W^W a better name for > this function. We already have m_getm2() which does the same for mbuf chains. > I utilized it in pfsync, however there are several other places where > it can be used instead of handrolled "if else if else" constructs. Handrolled mbuf allocation isn't good. Should be all in one place. -- Andre