From owner-svn-src-all@FreeBSD.ORG  Wed Oct 27 02:49:12 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E7DFB106566B;
	Wed, 27 Oct 2010 02:49:12 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D54C58FC13;
	Wed, 27 Oct 2010 02:49:12 +0000 (UTC)
Received: from xyf.my.dom (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9R2nAJ5095111;
	Wed, 27 Oct 2010 02:49:11 GMT (envelope-from davidxu@freebsd.org)
Message-ID: <4CC803A8.3040602@freebsd.org>
Date: Wed, 27 Oct 2010 10:49:12 +0000
From: David Xu <davidxu@freebsd.org>
User-Agent: Thunderbird 2.0.0.24 (X11/20100630)
MIME-Version: 1.0
To: Garrett Cooper <gcooper@freebsd.org>
References: <201010270232.o9R2Wsu3084553@svn.freebsd.org>
	<AANLkTi=2dTVmB8Goj+NXq4F6SmZBNS3bxn8gLjmQ+dfV@mail.gmail.com>
In-Reply-To: <AANLkTi=2dTVmB8Goj+NXq4F6SmZBNS3bxn8gLjmQ+dfV@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r214409 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Oct 2010 02:49:13 -0000

Garrett Cooper wrote:
> On Tue, Oct 26, 2010 at 7:32 PM, David Xu <davidxu@freebsd.org> wrote:
>> Author: davidxu
>> Date: Wed Oct 27 02:32:54 2010
>> New Revision: 214409
>> URL: http://svn.freebsd.org/changeset/base/214409
>>
>> Log:
>>  If input parameter cpusetsize is zero, give userland size of cpuset mask
>>  kernel is using.
>>
>> Modified:
>>  head/sys/kern/kern_cpuset.c
>>
>> Modified: head/sys/kern/kern_cpuset.c
>> ==============================================================================
>> --- head/sys/kern/kern_cpuset.c Wed Oct 27 02:07:25 2010        (r214408)
>> +++ head/sys/kern/kern_cpuset.c Wed Oct 27 02:32:54 2010        (r214409)
>> @@ -889,6 +889,10 @@ cpuset_getaffinity(struct thread *td, st
>>        int error;
>>        size_t size;
>>
>> +       if (uap->cpusetsize == 0) {
>> +               td->td_retval[0] = sizeof(cpuset_t);
>> +               return (0);
>> +       }
>>        if (uap->cpusetsize < sizeof(cpuset_t) ||
>>            uap->cpusetsize > CPU_MAXSIZE / NBBY)
>>                return (ERANGE);
> 
>     Isn't this requirement partly broken now?
> 
>      [ERANGE]           The cpusetsize was either preposterously large or
>                         smaller than the kernel set size.
> 
>     Why should cpuset(2) be broken in favor of people not passing valid values?
> Thanks,
> -Garrett
> 

I really hate to see such a problem that userland can not figure out
what kernel is using, I try hardly to guess, but still can not find
what it is using. yes, I think the doc may need to be fixed or
another syscall is needed.