From owner-svn-src-all@freebsd.org Wed Nov 20 18:02:46 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 430FC1BE46B for ; Wed, 20 Nov 2019 18:02:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47J9X516BCz49c1 for ; Wed, 20 Nov 2019 18:02:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x730.google.com with SMTP id q70so560592qke.12 for ; Wed, 20 Nov 2019 10:02:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b+64UMHSUDyRQfHTT3o2l/FNe558uwoowkF0LhPvDxE=; b=ArE25kUJTwgJrPqIg+3LcpPzCQhP5iANQH0RtavR+WTI75o12LCFXiUXJSM/ix5HWg MrBnNR2tIOakxLi8XZl8FcfPHf7a2GoByt0MtGx6ySrQVontWssBvqMxAcAHBbBGlJla tbLnYXeYBguQhltssVe54Nhr14y6Cj/R2fiCbUHlp8x+GvyZAVNU5sQDldKhXJVHGKhx MVo22hPF4g0lRESibUnrGQco/mcYAE/gikREBZC3p/TPgvZDCCpZ7GObPnTiO8tIU6GC Tb6a4IxCH9T72CaGw1S+gOEukoUDaXCTmIhK0yUATPeRJkbk+m977+537qKlIgyno3OX HY0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b+64UMHSUDyRQfHTT3o2l/FNe558uwoowkF0LhPvDxE=; b=ETa6HwdKsRvlRqmrR/9/G/MFpGtSIKc/feivzI77ojquJgI2e+sC7gVKt9ahf/Rd9v gJIN+gDYjFwA6i0soR3QSdepGtdeN0qET8HARBJp8sZi3B5hm70MJA0XcMmS2EE530Po FLwC8+nTa4+YNf1u6XybAzsfOwFm9/67Krd7W4sjRwW7oiye1XyGKMC0CY1oyQDZ7fxp Q+TQ5gE8oDH0SlCw4Bk8jLH8ytIsgZwgp31QLko30oxAl00SMvr2Qab7unCNS0vTaN6k sUvtx5JdOrbeMvBGsnQUS5qb9WGfwFlXg/SY4n3asUI4T/Zln6FpZDJz3SVxp/geZiIF 8Zlw== X-Gm-Message-State: APjAAAXFazsB8dLaeNKQSuJdvwOidPnVnLNrTjfQ+pqoF7XtK63OK+hQ TPkOCOieOH9kU32KfcMpEPf3ifeAfcFJ6BJkUtS41g== X-Google-Smtp-Source: APXvYqyDduqkyxXyd7QcDlGNA6hKcM3F4iclXYTV23cmm/SO1zDCGHqnhJgC7kBgR2iLIsAZOJ0FCR0a58wcRxoW16Y= X-Received: by 2002:a05:620a:200e:: with SMTP id c14mr3606840qka.380.1574272963884; Wed, 20 Nov 2019 10:02:43 -0800 (PST) MIME-Version: 1.0 References: <201911201635.xAKGZwT4082365@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 20 Nov 2019 11:02:32 -0700 Message-ID: Subject: Re: svn commit: r354899 - head/usr.sbin/jail To: Li-Wen Hsu Cc: John Baldwin , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 47J9X516BCz49c1 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=ArE25kUJ; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::730) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.73 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[0.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.73)[ip: (-9.33), ipnet: 2607:f8b0::/32(-2.30), asn: 15169(-1.97), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2019 18:02:46 -0000 On Wed, Nov 20, 2019 at 9:58 AM Li-Wen Hsu wrote: > On Thu, Nov 21, 2019 at 12:42 AM John Baldwin wrote: > > > > On 11/20/19 8:35 AM, Li-Wen Hsu wrote: > > > Author: lwhsu > > > Date: Wed Nov 20 16:35:58 2019 > > > New Revision: 354899 > > > URL: https://svnweb.freebsd.org/changeset/base/354899 > > > > > > Log: > > > Limit the workaround to riscv only > > > > > > PR: 242109 > > > Sponsored by: The FreeBSD Foundation > > > > > > Modified: > > > head/usr.sbin/jail/Makefile > > > > > > Modified: head/usr.sbin/jail/Makefile > > > > ============================================================================== > > > --- head/usr.sbin/jail/Makefile Wed Nov 20 16:32:13 2019 > (r354898) > > > +++ head/usr.sbin/jail/Makefile Wed Nov 20 16:35:58 2019 > (r354899) > > > @@ -18,7 +18,9 @@ CFLAGS+=-I. -I${.CURDIR} > > > # workaround for GNU ld (GNU Binutils) 2.33.1: > > > # relocation truncated to fit: R_RISCV_GPREL_I against `.LANCHOR2' > > > # https://bugs.freebsd.org/242109 > > > +.if ${MACHINE_ARCH} == "riscv" > > > CFLAGS+=-Wl,--no-relax > > > +.endif > > > > Eh, will that work? I think MACHINE and MACHINE_CPUARCH are riscv, > > but MACHINE_ARCH is riscv64 and riscv64sf. > > No it doesn't. I was too lazy to do scp from test machine to commit > machine and caused a copy-n-paste error, but ${MACHINE} should be > better since it covers more. > No. MACHINE_CPUARCH is better because it is userland. This isn't a kernel interface thing, so MACHINE is the wrong thing to use. Warner > > Also, it would be good to wrap this in .if ${LINKER_TYPE} == "bfd" I > think. > > Also added in r354900. Thanks for the suggestion. > > > (I was able to build a world + kernel with lld earlier this week, though > it > > doesn't yet boot) > > Looking forward to building world & kernel with llvm toolchain. > > Thanks, > Li-Wen >