From owner-svn-src-all@FreeBSD.ORG  Wed Jun 20 21:15:26 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A7DA81065678
	for <svn-src-all@freebsd.org>; Wed, 20 Jun 2012 21:15:26 +0000 (UTC)
	(envelope-from wlosh@bsdimp.com)
Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com
	[209.85.210.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 429BD8FC21
	for <svn-src-all@freebsd.org>; Wed, 20 Jun 2012 21:15:26 +0000 (UTC)
Received: by dadv36 with SMTP id v36so11266835dad.13
	for <svn-src-all@freebsd.org>; Wed, 20 Jun 2012 14:15:25 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=subject:mime-version:content-type:from:in-reply-to:date:cc
	:content-transfer-encoding:message-id:references:to:x-mailer
	:x-gm-message-state;
	bh=n2mAkYYH1H2kamlAz3EniseVJXGHI7N0jq/5RY4zn6o=;
	b=FDFJx7GSZcTzYjzgnOoD0XskgD0+CV/+hVBCsJ9i1xnxy2LGNK2/5x9QAFpTT0cDID
	+5jq57OPRKQFAsdT7vSoz7OeCM91YNDpuLzrYC8e8YWiJ9jsILSDooyt0bYOjDCf6Jy8
	xzMQMBKPY3OFj1kRorCdvJl+bwuOB9f3wbEAyb0G59dA6hx+LZ/lyb1fSjYtdX1xn536
	+HfatBYwGwP56w9R9wvKybH3XGBm8UJVH+ISEJde+iPJzQxLvrRrFfpgn0KHLxOip7eY
	Z+ckvbcyLyA/tl1Lz4AnJL5+G5NCkpyd5X02PrXbxo5JKLvVwkPP/gut9mEi8HAASN/o
	Av1A==
Received: by 10.68.231.40 with SMTP id td8mr82026057pbc.150.1340226925859;
	Wed, 20 Jun 2012 14:15:25 -0700 (PDT)
Received: from [10.30.101.53] ([209.117.142.2])
	by mx.google.com with ESMTPS id he9sm33186270pbc.68.2012.06.20.14.15.24
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 20 Jun 2012 14:15:25 -0700 (PDT)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <wlosh@bsdimp.com>
In-Reply-To: <4FE1FC23.9000904@freebsd.org>
Date: Wed, 20 Jun 2012 15:15:17 -0600
Content-Transfer-Encoding: 7bit
Message-Id: <690DF487-F7CB-421E-B6BC-F7CE6BC0F658@bsdimp.com>
References: <201206200638.q5K6cg7u024024@svn.freebsd.org>
	<20120621015220.J2636@besplex.bde.org>
	<4FE1FC23.9000904@freebsd.org>
To: Colin Percival <cperciva@FreeBSD.org>
X-Mailer: Apple Mail (2.1084)
X-Gm-Message-State: ALoCoQkzmDNk4/O/poyvzqxBZ+X48d6bpAoe4uylneBY3y+vBXc54kqzf53DDMi5f9nIh8YjQze4
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Eitan Adler <eadler@freebsd.org>,
	Bruce Evans <brde@optusnet.com.au>
Subject: Re: svn commit: r237286 - head/lib/libc/gen
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2012 21:15:26 -0000


On Jun 20, 2012, at 10:36 AM, Colin Percival wrote:

> On 06/20/12 09:27, Bruce Evans wrote:
>> On Wed, 20 Jun 2012, Eitan Adler wrote:
>>> Log:
>>> Don't close an uninitialized descriptor. [1]
>>> Add a sanity check for the validity of the passed fd.
>> 
>> Library functions shouldn't use assert() or abort().
> 
> Why not?

We've tried to avoid things that make the library dump core...

Warner