From owner-freebsd-net@FreeBSD.ORG Fri Jan 23 01:50:54 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 49A44D1D; Fri, 23 Jan 2015 01:50:54 +0000 (UTC) Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D1596662; Fri, 23 Jan 2015 01:50:51 +0000 (UTC) Received: from ns.kevlo.org (localhost [127.0.0.1]) by ns.kevlo.org (8.14.9/8.14.9) with ESMTP id t0N1n0vQ057578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 23 Jan 2015 09:49:01 +0800 (CST) (envelope-from kevlo@ns.kevlo.org) Received: (from kevlo@localhost) by ns.kevlo.org (8.14.9/8.14.9/Submit) id t0N1mlD0057577; Fri, 23 Jan 2015 09:48:47 +0800 (CST) (envelope-from kevlo) Date: Fri, 23 Jan 2015 09:48:45 +0800 From: Kevin Lo To: Will Andrews Subject: Re: MFC of if_lagg flowid changes (r272386)? Message-ID: <20150123014845.GA57563@ns.kevlo.org> References: <20150122191722.GB49380@sol.firepipe.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150122191722.GB49380@sol.firepipe.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-net@freebsd.org, adrian@freebsd.org, hrs@freebsd.org, emax@freebsd.org, asomers@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 01:50:54 -0000 On Thu, Jan 22, 2015 at 12:17:23PM -0700, Will Andrews wrote: > Hi, > > Please see: > https://svnweb.freebsd.org/base?view=revision&revision=272386 > > This change removes sysctl nodes that were added during lacp_attach(), which > causes a lock order reversal (sleepable lock while holding non-sleepable). > > These sysctl nodes arrived in: > https://svnweb.freebsd.org/base?view=revision&revision=253687 > > Here is a bug report about the LOR: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=188997 > > I propose to MFC r272386 to eliminate the bug. However, it also eliminates > sysctl nodes that were added to control lagg behavior. My understanding is > that these sysctls weren't intended to be publicly used, and consequently > they aren't documented anywhere. The strict mode for LACP can be disabled by ifconfig(8): #ifconfig lagg0 -lacp_strict hrs@ told me he would add lacp_strict option to the manual page. > Any objections? No. :-) > Thanks! > -- > wca Kevin