From owner-svn-ports-all@freebsd.org Tue Jul 3 06:58:45 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D264C1022186; Tue, 3 Jul 2018 06:58:44 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 72A5970518; Tue, 3 Jul 2018 06:58:44 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (unknown [IPv6:2a01:678:42:ffff:3e15:c2ff:fec4:452e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 9280511D06; Tue, 3 Jul 2018 06:58:43 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Tue, 3 Jul 2018 08:58:39 +0200 From: Mathieu Arnold To: "Timur I. Bakeyev" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r473793 - in head/devel: . cwrap nss_wrapper pam_wrapper resolv_wrapper socket_wrapper uid_wrapper Message-ID: <20180703065839.2oqenluilcdzkl6d@atuin.in.mat.cc> References: <201807030329.w633ThS8056768@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="putgy4o5cjrp5tvd" Content-Disposition: inline In-Reply-To: <201807030329.w633ThS8056768@repo.freebsd.org> User-Agent: NeoMutt/20180323 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 06:58:45 -0000 --putgy4o5cjrp5tvd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 03, 2018 at 03:29:43AM +0000, Timur I. Bakeyev wrote: > Added: head/devel/nss_wrapper/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/nss_wrapper/Makefile Tue Jul 3 03:29:42 2018 (r473793) > @@ -0,0 +1,37 @@ > +# $FreeBSD$ > + > +PORTNAME=3D nss_wrapper > +PORTVERSION=3D 1.1.3 > +CATEGORIES=3D devel > +MASTER_SITES=3D SAMBA/cwrap > + > +MAINTAINER=3D timur@FreeBSD.org > +COMMENT=3D Wrapper for the user, group and hosts NSS API > + > +LICENSE=3D GPLv3 > + > +USES=3D cmake:outsource perl5 shebangfix > +USE_PERL5=3D run > +USE_LDCONFIG=3D yes > + > +CMAKE_ARGS+=3D -DMAN_INSTALL_DIR:PATH=3D"${PREFIX}/man" Why +=3D? > +OPTIONS_DEFINE=3D TEST > +OPTIONS_DEFAULT=3D TEST > + > +TEST_TARGET=3D test Fun fact, TEST_TARGET may not do what you think it does. What it does is tell the framework that the target to run when running `make test` is test, which will probably fail if the TEST option is not enabled. What you may have meant to set was TEST_TEST_TARGET, which sets TEST_TARGET when the TEST option is enabled. > +TEST_CMAKE_BOOL=3D UNIT_TESTING > +TEST_BUILD_DEPENDS+=3D cmocka>=3D1.1.1:sysutils/cmocka Why +=3D? > +SHEBANG_FILES=3D nss_wrapper.pl > + > +PLIST_FILES=3D bin/nss_wrapper.pl \ > + libdata/pkgconfig/nss_wrapper.pc \ > + lib/cmake/nss_wrapper/nss_wrapper-config-version.cmake \ > + lib/cmake/nss_wrapper/nss_wrapper-config.cmake \ > + lib/libnss_wrapper.so.0.2.3 \ > + lib/libnss_wrapper.so.0 \ > + lib/libnss_wrapper.so \ > + man/man1/nss_wrapper.1.gz These are a lot of files, you should probably be using a pkg-plist file instead. > Added: head/devel/pam_wrapper/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/pam_wrapper/Makefile Tue Jul 3 03:29:42 2018 (r473793) > @@ -0,0 +1,47 @@ > +# $FreeBSD$ > + > +PORTNAME=3D pam_wrapper > +PORTVERSION=3D 1.0.6 > +CATEGORIES=3D devel > +MASTER_SITES=3D SAMBA/cwrap > + > +MAINTAINER=3D timur@FreeBSD.org > +COMMENT=3D Preloadable wrapper to test PAM applications and PAM Modules > + > +LICENSE=3D GPLv3 > + > +USES=3D cmake:outsource python:2.7+ > +USE_LDCONFIG=3D yes > + > +CMAKE_ARGS+=3D -DMAN_INSTALL_DIR:PATH=3D"${PREFIX}/man" Why +=3D? > +OPTIONS_DEFINE=3D TEST > +OPTIONS_DEFAULT=3D TEST > + > +TEST_TARGET=3D test Same remark. > +TEST_CMAKE_BOOL=3D UNIT_TESTING > +TEST_BUILD_DEPENDS+=3D cmocka>=3D1.1.1:sysutils/cmocka Why +=3D? > +PLIST_FILES=3D libdata/pkgconfig/pam_wrapper.pc \ > + libdata/pkgconfig/libpamtest.pc \ > + lib/cmake/pam_wrapper/pam_wrapper-config-version.cmake \ > + lib/cmake/pam_wrapper/pam_wrapper-config.cmake \ > + lib/cmake/libpamtest/libpamtest-config.cmake \ > + lib/cmake/libpamtest/libpamtest-config-version.cmake \ > + lib/libpam_wrapper.so.0.0.3 \ > + lib/libpam_wrapper.so.0 \ > + lib/libpam_wrapper.so \ > + lib/libpamtest.so.0.0.3 \ > + lib/libpamtest.so.0 \ > + lib/libpamtest.so \ > + lib/pam_wrapper/pam_matrix.so \ > + lib/pam_wrapper/pam_get_items.so \ > + lib/pam_wrapper/pam_set_items.so \ > + ${PYTHON_SITELIBDIR}/pypamtest.so \ > + include/libpamtest.h \ > + man/man1/pam_wrapper.1.gz \ > + man/man8/pam_matrix.8.gz \ > + man/man8/pam_get_items.8.gz \ > + man/man8/pam_set_items.8.gz Way too many files to be using PLIST_FILES, please use a pkg-plist file. > Added: head/devel/resolv_wrapper/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/resolv_wrapper/Makefile Tue Jul 3 03:29:42 2018 (r473793) > @@ -0,0 +1,33 @@ > +# $FreeBSD$ > + > +PORTNAME=3D resolv_wrapper > +PORTVERSION=3D 1.1.5 > +CATEGORIES=3D devel > +MASTER_SITES=3D SAMBA/cwrap > + > +MAINTAINER=3D timur@FreeBSD.org > +COMMENT=3D Wrapper for dns name resolving or dns faking > + > +LICENSE=3D GPLv3 > + > +USES=3D cmake:outsource > +USE_LDCONFIG=3D yes > + > +CMAKE_ARGS+=3D -DMAN_INSTALL_DIR:PATH=3D"${PREFIX}/man" Why +=3D? > +OPTIONS_DEFINE=3D TEST > +OPTIONS_DEFAULT=3D TEST > + > +TEST_TARGET=3D test Same. > +TEST_CMAKE_BOOL=3D UNIT_TESTING > +TEST_BUILD_DEPENDS+=3D cmocka>=3D1.1.1:sysutils/cmocka Why +=3D? > +PLIST_FILES=3D libdata/pkgconfig/resolv_wrapper.pc \ > + lib/cmake/resolv_wrapper/resolv_wrapper-config-version.cmake \ > + lib/cmake/resolv_wrapper/resolv_wrapper-config.cmake \ > + lib/libresolv_wrapper.so.0.0.5 \ > + lib/libresolv_wrapper.so.0 \ > + lib/libresolv_wrapper.so \ > + man/man1/resolv_wrapper.1.gz Same. > Added: head/devel/socket_wrapper/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/socket_wrapper/Makefile Tue Jul 3 03:29:42 2018 (r473793) > @@ -0,0 +1,37 @@ > +# $FreeBSD$ > + > +PORTNAME=3D socket_wrapper > +PORTVERSION=3D 1.1.9 > +CATEGORIES=3D devel > +MASTER_SITES=3D SAMBA/cwrap > + > +MAINTAINER=3D timur@FreeBSD.org > +COMMENT=3D Library passing all socket communications through unix socke= ts > + > +LICENSE=3D GPLv3 > + > +USES=3D cmake:outsource > +USE_LDCONFIG=3D yes > + > +CMAKE_ARGS+=3D -DMAN_INSTALL_DIR:PATH=3D"${PREFIX}/man" Why +=3D? > +OPTIONS_DEFINE=3D TEST > +OPTIONS_DEFAULT=3D TEST > + > +TEST_TARGET=3D test Same. > +TEST_CMAKE_BOOL=3D UNIT_TESTING > +TEST_BUILD_DEPENDS+=3D cmocka>=3D1.1.1:sysutils/cmocka Why +=3D? > +PLIST_FILES=3D libdata/pkgconfig/socket_wrapper.pc \ > + lib/cmake/socket_wrapper/socket_wrapper-config-version.cmake \ > + lib/cmake/socket_wrapper/socket_wrapper-config.cmake \ > + lib/libsocket_wrapper.so.0.1.9 \ > + lib/libsocket_wrapper.so.0 \ > + lib/libsocket_wrapper.so \ > + man/man1/socket_wrapper.1.gz Same. > Added: head/devel/uid_wrapper/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/uid_wrapper/Makefile Tue Jul 3 03:29:42 2018 (r473793) > @@ -0,0 +1,33 @@ > +# $FreeBSD$ > + > +PORTNAME=3D uid_wrapper > +PORTVERSION=3D 1.2.4 > +CATEGORIES=3D devel > +MASTER_SITES=3D SAMBA/cwrap > + > +MAINTAINER=3D timur@FreeBSD.org > +COMMENT=3D Wrapper to fake privilege separation > + > +LICENSE=3D GPLv3 > + > +USES=3D cmake:outsource > +USE_LDCONFIG=3D yes > + > +CMAKE_ARGS+=3D -DMAN_INSTALL_DIR:PATH=3D"${PREFIX}/man" Why +=3D? > +OPTIONS_DEFINE=3D TEST > +OPTIONS_DEFAULT=3D TEST > + > +TEST_TARGET=3D test Same. > +TEST_CMAKE_BOOL=3D UNIT_TESTING > +TEST_BUILD_DEPENDS+=3D cmocka>=3D1.1.1:sysutils/cmocka Why +=3D? > +PLIST_FILES=3D libdata/pkgconfig/uid_wrapper.pc \ > + lib/cmake/uid_wrapper/uid_wrapper-config-version.cmake \ > + lib/cmake/uid_wrapper/uid_wrapper-config.cmake \ > + lib/libuid_wrapper.so.0.0.6 \ > + lib/libuid_wrapper.so.0 \ > + lib/libuid_wrapper.so \ > + man/man1/uid_wrapper.1.gz Same. --=20 Mathieu Arnold --putgy4o5cjrp5tvd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAls7Hp9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkhLaw//VYPeS3Z70Hwu2AYQ1aUD5N3U7zeJo6zji3HzDpTlVk8lW3ktHqCoNgSj 6nVroZzhw6pA/sxvKuZaRETinbkQlefXPV2uXaL1x6C9Z5BOgUwywz+XqQreVOpv yGoE32c9wpMaSICvJz5wMbBhvIjTzZ779mA3Uj4hU8jUTTezVGTRjRP+LpiW+1x5 uAsQ/I1HWeUg01WjXOmGwVqfuyA9K8l8pzRwe+G70yjEepU641xh1+mI1gD2OTy6 TVVl3PWwLqos+Y3JiHo4uu4urOkgVd/Qhbp/zRCesSIa3M2QE5DSdpss9xL9W5mW lKXyfSEmVkpvAukXkQ9OZHy7G8k57eLXL0WiYrkGjZ5ndqyzZGjAbvBaNWBM7ijY mwG6X4yZ6f6tEjARuXjQGtsRKfrbTpdeQuiJtDp9ARia/hTPEzRzA8h4Mj3Db5Ve 0MlBfy2vvs5FkTy7/ZGfuhlRvAXRMKjPKkvXKUHXiezqZZZZ403xPHVXPVkSExRA RjZxsxvI8vDB+LhGci6w5jTnFe9xfEmEVNslo9iYHddqmVHT8Tim9lHvSZHEMzwQ +iu91wUy9KYDUhCffOEAyk0mKcjwsdD4/EoWCRsGe1YQCEMNSW5RhUTHe66cAnhU RRL2zMR3QnkCxXPMNljSt6/1yqEw6s1t8VKc0+EoeOattkV6a2Q= =le+h -----END PGP SIGNATURE----- --putgy4o5cjrp5tvd--